github/ValueScript
1
1
Fork 0
mirror of https://github.com/voltrevo/ValueScript.git synced 2026-05-10 03:00:06 -04:00
Code Issues Packages Projects Releases Wiki Activity

Deduplicate code

Browse Source
This commit is contained in:
Andrew Morris
2023-03-01 18:44:46 +11:00
parent f3118298fe
commit 5ea2903b90
1 changed files with 1 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
valuescript_compiler/src/expression_compiler.rs
View File

@@ -1574,46 +1574,7 @@ impl TargetAccessor {
use swc_ecma_ast::Expr::*;
return match expr {
Ident(ident) => match ec.scope.get(&ident.sym.to_string()) {
None => {
ec.fnc.diagnostics.push(Diagnostic {
level: DiagnosticLevel::Error,
span: ident.span,
message: format!("Unresolved identifier: {}", ident.sym.to_string()),
});
TargetAccessor::make_bad(ec)
}
Some(MappedName::Definition(def_name)) => {
ec.fnc.diagnostics.push(Diagnostic {
level: DiagnosticLevel::Error,
span: ident.span,
message: format!("Cannot assign to definition: {}", def_name),
});
TargetAccessor::make_bad(ec)
}
Some(MappedName::QueuedFunction(qfn)) => {
ec.fnc.diagnostics.push(Diagnostic {
level: DiagnosticLevel::Error,
span: ident.span,
message: format!("Cannot assign to function: {}", qfn.definition_name),
});
TargetAccessor::make_bad(ec)
}
Some(MappedName::Register(reg)) => TargetAccessor::Register(reg),
// Some(MappedName::Builtin(_)) => None,
Some(MappedName::Builtin(builtin)) => {
ec.fnc.diagnostics.push(Diagnostic {
level: DiagnosticLevel::Error,
span: ident.span,
message: format!("Cannot assign to builtin: {}", builtin),
});
TargetAccessor::make_bad(ec)
}
},
Ident(ident) => TargetAccessor::Register(ec.get_register_for_ident_mutation(ident)),
This(_) => TargetAccessor::Register("this".to_string()),
Member(member) => {
let obj = TargetAccessor::compile(ec, &member.obj);