Use &Val for submov key

valuescript_vm/src/builtins/builtin_object.rs

@@ -70,7 +70,7 @@ where
     Ok(Self::bo_sub(&key.to_string()))
   }
 
-  fn submov(&mut self, _key: Val, _value: Val) -> Result<(), Val> {
+  fn submov(&mut self, _key: &Val, _value: Val) -> Result<(), Val> {
     Err(format!("Cannot assign to subscript of {} builtin", Self::bo_name()).to_type_error())
   }
 

valuescript_vm/src/builtins/error_builtin.rs

@@ -98,7 +98,7 @@ static SET_MESSAGE: NativeFunction = native_fn(|mut this, params| {
     None => "".to_string(),
   };
 
-  op_submov(this.get_mut()?, "message".to_val(), message.to_val())?;
+  op_submov(this.get_mut()?, &"message".to_val(), message.to_val())?;
 
   Ok(Val::Undefined)
 });

valuescript_vm/src/builtins/range_error_builtin.rs

@@ -62,7 +62,7 @@ static SET_MESSAGE: NativeFunction = native_fn(|mut this, params| {
     None => "".to_string(),
   };
 
-  op_submov(this.get_mut()?, "message".to_val(), message.to_val())?;
+  op_submov(this.get_mut()?, &"message".to_val(), message.to_val())?;
 
   Ok(Val::Undefined)
 });

valuescript_vm/src/builtins/type_error_builtin.rs

@@ -70,7 +70,7 @@ static SET_MESSAGE: NativeFunction = native_fn(|mut this, params| {
     None => "".to_string(),
   };
 
-  op_submov(this.get_mut()?, "message".to_val(), message.to_val())?;
+  op_submov(this.get_mut()?, &"message".to_val(), message.to_val())?;
 
   Ok(Val::Undefined)
 });

valuescript_vm/src/bytecode_stack_frame.rs

@@ -302,13 +302,13 @@ impl StackFrameTrait for BytecodeStackFrame {
       Sub => self.apply_binary_op(operations::op_sub)?,
 
       SubMov => {
-        let subscript = self.decoder.decode_val(&self.registers);
+        let subscript = self.decoder.decode_vallish(&self.registers);
         let value = self.decoder.decode_val(&self.registers);
 
         let register_index = self.decoder.decode_register_index().unwrap();
         let mut target = self.registers[register_index].clone(); // TODO: Lift
 
-        operations::op_submov(&mut target, subscript, value)?;
+        operations::op_submov(&mut target, subscript.get_ref(), value)?;
         self.registers[register_index] = target;
       }
 

valuescript_vm/src/generator.rs

@@ -89,7 +89,7 @@ impl ValTrait for Generator {
     Ok(Val::Undefined)
   }
 
-  fn submov(&mut self, _key: Val, _value: Val) -> Result<(), Val> {
+  fn submov(&mut self, _key: &Val, _value: Val) -> Result<(), Val> {
     Err("Cannot assign to subscript of a generator".to_type_error())
   }
 

valuescript_vm/src/iteration/array_entries_iterator.rs

@@ -87,7 +87,7 @@ impl ValTrait for ArrayEntriesIterator {
     Ok(Val::Undefined)
   }
 
-  fn submov(&mut self, _key: Val, _value: Val) -> Result<(), Val> {
+  fn submov(&mut self, _key: &Val, _value: Val) -> Result<(), Val> {
     Err("Cannot assign to subscript of array iterator".to_type_error())
   }
 

valuescript_vm/src/iteration/array_iterator.rs

@@ -87,7 +87,7 @@ impl ValTrait for ArrayIterator {
     Ok(Val::Undefined)
   }
 
-  fn submov(&mut self, _key: Val, _value: Val) -> Result<(), Val> {
+  fn submov(&mut self, _key: &Val, _value: Val) -> Result<(), Val> {
     Err("Cannot assign to subscript of array iterator".to_type_error())
   }
 

valuescript_vm/src/iteration/iteration_result.rs

@@ -69,7 +69,7 @@ impl ValTrait for IterationResult {
     })
   }
 
-  fn submov(&mut self, _key: Val, _value: Val) -> Result<(), Val> {
+  fn submov(&mut self, _key: &Val, _value: Val) -> Result<(), Val> {
     Err("Cannot assign to subscript of iteration result".to_type_error())
   }
 

valuescript_vm/src/iteration/string_iterator.rs

@@ -123,7 +123,7 @@ impl ValTrait for StringIterator {
     Ok(Val::Undefined)
   }
 
-  fn submov(&mut self, _key: Val, _value: Val) -> Result<(), Val> {
+  fn submov(&mut self, _key: &Val, _value: Val) -> Result<(), Val> {
     Err("Cannot assign to subscript of string iterator".to_type_error())
   }
 

valuescript_vm/src/native_frame_function.rs

@@ -63,7 +63,7 @@ impl ValTrait for NativeFrameFunction {
     Err("TODO: Subscript native function".to_error())
   }
 
-  fn submov(&mut self, _key: Val, _value: Val) -> Result<(), Val> {
+  fn submov(&mut self, _key: &Val, _value: Val) -> Result<(), Val> {
     Err("Cannot assign to subscript of native function".to_type_error())
   }
 

valuescript_vm/src/native_function.rs

@@ -84,7 +84,7 @@ impl ValTrait for NativeFunction {
     Err("TODO: Subscript native function".to_error())
   }
 
-  fn submov(&mut self, _key: Val, _value: Val) -> Result<(), Val> {
+  fn submov(&mut self, _key: &Val, _value: Val) -> Result<(), Val> {
     Err("Cannot assign to subscript of native function".to_type_error())
   }
 

valuescript_vm/src/operations.rs

@@ -470,7 +470,7 @@ pub fn op_sub(left: Vallish, right: Vallish) -> Result<Val, Val> {
   }
 }
 
-pub fn op_submov(target: &mut Val, subscript: Val, value: Val) -> Result<(), Val> {
+pub fn op_submov(target: &mut Val, subscript: &Val, value: Val) -> Result<(), Val> {
   match target {
     Val::Void => Err("Internal: Shouldn't happen".to_error()), // TODO: Internal errors
     Val::Undefined => Err("Cannot assign to subscript of undefined".to_type_error()),
@@ -510,7 +510,7 @@ pub fn op_submov(target: &mut Val, subscript: Val, value: Val) -> Result<(), Val
 
       match subscript {
         Val::String(string) => object_data_mut.string_map.insert(string.to_string(), value),
-        Val::Symbol(symbol) => object_data_mut.symbol_map.insert(symbol, value),
+        Val::Symbol(symbol) => object_data_mut.symbol_map.insert(symbol.clone(), value),
         _ => object_data_mut
           .string_map
           .insert(subscript.to_string(), value),

valuescript_vm/src/vs_array.rs

@@ -150,7 +150,7 @@ impl ValTrait for ArrayPrototype {
     }))
   }
 
-  fn submov(&mut self, _key: Val, _value: Val) -> Result<(), Val> {
+  fn submov(&mut self, _key: &Val, _value: Val) -> Result<(), Val> {
     Err("Cannot assign to subscript of Array.prototype".to_type_error())
   }
 

valuescript_vm/src/vs_value.rs

@@ -81,7 +81,7 @@ pub trait ValTrait: fmt::Display {
   fn load_function(&self) -> LoadFunctionResult;
 
   fn sub(&self, key: &Val) -> Result<Val, Val>;
-  fn submov(&mut self, key: Val, value: Val) -> Result<(), Val>;
+  fn submov(&mut self, key: &Val, value: Val) -> Result<(), Val>;
 
   fn pretty_fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result;
   fn codify(&self) -> String;
@@ -356,7 +356,7 @@ impl ValTrait for Val {
     op_sub(Vallish::Ref(self), Vallish::Ref(key))
   }
 
-  fn submov(&mut self, key: Val, value: Val) -> Result<(), Val> {
+  fn submov(&mut self, key: &Val, value: Val) -> Result<(), Val> {
     op_submov(self, key, value)
   }