github/ValueScript
1
1
Fork 0
mirror of https://github.com/voltrevo/ValueScript.git synced 2026-04-18 03:00:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Simplify and improve handle_releases_impl

Browse Source
This commit is contained in:
Andrew Morris
2023-07-01 10:03:32 +10:00
parent 7ad17b73b6
commit e3f611cf59
3 changed files with 6 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
valuescript_compiler/src/optimization/simplify.rs
View File

@@ -324,16 +324,15 @@ impl FnState {
released_reg: Register,
skips_needed: usize,
) {
// Search backwards to find where this register was last written. If a jump instruction occurs,
// then we don't know for sure whether the release point will be hit, and we can't apply our
// analysis.
let mut j = i + 1;
let mut skips = 0;
let mut taken = false;
while j > 0 {
j -= 1;
let instr = match &mut body[j] {
FnLine::Instruction(instr) => instr,
FnLine::Label(_) => return,
_ => continue,
};
@@ -343,42 +342,10 @@ impl FnState {
let mut write_found = false;
instr.visit_registers_mut_rev(&mut |rvm| {
if skips < skips_needed {
skips += 1;
return;
}
if rvm.write && rvm.register.name == released_reg.name {
write_found = true;
}
});
if write_found {
break;
}
}
// Now that we've established that the last write always hits the release point, find the last
// read and use .take() instead of copying. Also, if this .take() never occurs, it means the
// value was never used, and comment out the instruction that writes the value, if possible.
let mut j = i + 1;
let mut skip_i = 0;
let mut taken = false;
while j > 0 {
j -= 1;
let instr = match &mut body[j] {
FnLine::Instruction(instr) => instr,
_ => continue,
};
let mut write_found = false;
if !taken {
instr.visit_registers_mut_rev(&mut |rvm| {
if skip_i < skips_needed {
skip_i += 1;
if skips < skips_needed {
skips += 1;
return;
}