github/ValueScript
1
1
Fork 0
mirror of https://github.com/voltrevo/ValueScript.git synced 2026-04-18 03:00:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use .effectively_const to exclude from TargetAccessor, producing const_subcall

Browse Source
This commit is contained in:
Andrew Morris
2023-04-04 14:55:32 +10:00
parent f728509db9
commit f2db17ef27
2 changed files with 20 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
valuescript_compiler/src/expression_compiler.rs
View File

@@ -998,20 +998,27 @@ impl<'a> ExpressionCompiler<'a> {
}
};
let instr = Instruction::SubCall(
obj_value.clone(),
prop.value,
Value::Array(Box::new(asm_args)),
dest.clone(),
);
self.fnc.push(instr);
match obj {
TargetAccessorOrCompiledExpression::TargetAccessor(mut ta) => {
let instr = Instruction::SubCall(
obj_value.clone(),
prop.value,
Value::Array(Box::new(asm_args)),
dest.clone(),
);
self.fnc.push(instr);
ta.assign_and_packup(self, &obj_value);
}
TargetAccessorOrCompiledExpression::CompiledExpression(ce) => {
let instr = Instruction::ConstSubCall(
obj_value.clone(),
prop.value,
Value::Array(Box::new(asm_args)),
dest.clone(),
);
self.fnc.push(instr);
self.fnc.use_(ce);
}
}
@@ -1669,9 +1676,9 @@ impl TargetAccessor {
use swc_ecma_ast::Expr::*;
return match expr {
Ident(ident) => match ec.fnc.lookup_value(ident) {
Some(Value::Register(_)) => true,
_ => false,
Ident(ident) => match ec.fnc.lookup(ident) {
Some(name) => !name.effectively_const,
_ => false, // TODO: InternalError?
},
This(_) => true,
Member(member) => TargetAccessor::is_eligible_expr(ec, &member.obj),