From 020326ffad6bf8dffe52e76591ab2d58d62f5e02 Mon Sep 17 00:00:00 2001
From: probablycorey <cj@github.com>
Date: Wed, 22 Jan 2014 16:01:52 -0800
Subject: [PATCH] Only display one dialog on successful installation.

---
 src/workspace-view.coffee | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/src/workspace-view.coffee b/src/workspace-view.coffee
index fa4babeca..fffebd826 100644
--- a/src/workspace-view.coffee
+++ b/src/workspace-view.coffee
@@ -135,23 +135,24 @@ class WorkspaceView extends View
     @command 'core:save-as', => @saveActivePaneItemAs()
 
   installShellCommands: ->
-    showDialog = (error, commandName)->
-      if error?
-        installDirectory = CommandInstaller.getInstallDirectory()
-        atom.confirm
-          message: error.message
-          detailedMessage: "Make sure #{CommandInstaller.getInstallDirectory()} exists and is writable. Run 'sudo mkdir -p #{installDirectory} && sudo chown $USER #{installDirectory}' to fix this problem."
-      else
-        atom.confirm
-          message: "Command installed."
-          detailedMessage: "The shell command `#{commandName}` is installed."
+    showErrorDialog = (error) ->
+      installDirectory = CommandInstaller.getInstallDirectory()
+      atom.confirm
+        message: error.message
+        detailedMessage: "Make sure #{installDirectory} exists and is writable. Run 'sudo mkdir -p #{installDirectory} && sudo chown $USER #{installDirectory}' to fix this problem."
 
     resourcePath = atom.getLoadSettings().resourcePath
     CommandInstaller.installAtomCommand resourcePath, (error) =>
-      showDialog(error, 'atom')
-      unless error?
+      if error?
+        showDialog(error)
+      else
         CommandInstaller.installApmCommand resourcePath, (error) =>
-          showDialog(error, 'apm')
+          if error?
+            showDialog(error)
+          else
+            atom.confirm
+              message: "Commands installed."
+              detailedMessage: "The shell commands `atom` and `apm` are installed."
 
   # Private:
   handleFocus: (e) ->