From 05bcd3e5e0f8a5c9643b81cb032cd15d7f6f11ee Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Thu, 26 Apr 2012 11:59:47 -0600 Subject: [PATCH] =?UTF-8?q?Fix=20EventEmitter=E2=80=A6=20need=20to=20wait?= =?UTF-8?q?=20until=20after=20the=20loop=20to=20return!?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- spec/app/event-emitter-spec.coffee | 2 +- src/app/event-emitter.coffee | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/app/event-emitter-spec.coffee b/spec/app/event-emitter-spec.coffee index 76bac0284..ced8951ac 100644 --- a/spec/app/event-emitter-spec.coffee +++ b/spec/app/event-emitter-spec.coffee @@ -1,7 +1,7 @@ _ = require 'underscore' EventEmitter = require 'event-emitter' -describe "EventEmitter mixin", -> +fdescribe "EventEmitter mixin", -> [object, fooHandler1, fooHandler2, barHandler] = [] beforeEach -> diff --git a/src/app/event-emitter.coffee b/src/app/event-emitter.coffee index 387038453..a1ea474df 100644 --- a/src/app/event-emitter.coffee +++ b/src/app/event-emitter.coffee @@ -36,13 +36,13 @@ module.exports = for handler in new Array(handlers...) _.remove(handlers, handler) @off eventName, handler - return + return else for eventName, handlers of @eventHandlersByNamespace?[namespace] ? {} for handler in new Array(handlers...) _.remove(handlers, handler) @off eventName, handler - return + return else if handler _.remove(@eventHandlersByEventName[eventName], handler)