github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-18 10:31:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make Renderer.proto.buildLinesForBufferRows iterative instead of recursive

Browse Source 
So we don't stack overflow on very large files.
This commit is contained in:
Nathan Sobo
2012-04-09 15:48:13 -06:00
parent f9ee35dc87
commit 0ad9e7b83b
1 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/app/renderer.coffee
View File

@@ -133,14 +133,19 @@ class Renderer
@buildLinesForBufferRows(bufferRow, bufferRow)
buildLinesForBufferRows: (startBufferRow, endBufferRow) ->
recursiveBuildLinesForBufferRows = (startBufferRow, endBufferRow, startBufferColumn, currentScreenLineLength=0) =>
return [] if startBufferRow > endBufferRow and not startBufferColumn?
lineFragments = []
startBufferColumn = null
currentScreenLineLength = 0
startBufferRow = @foldStartRowForBufferRow(startBufferRow)
loop
break if startBufferRow > endBufferRow and not startBufferColumn?
startBufferColumn ?= 0
line = @highlighter.lineForRow(startBufferRow).splitAt(startBufferColumn)[1]
line = @highlighter.lineForRow(startBufferRow)
line = line.splitAt(startBufferColumn)[1]
wrapScreenColumn = @findWrapColumn(line.text, @maxLineLength - currentScreenLineLength)
continueMainLoop = false
for fold in @foldsForBufferRow(startBufferRow)
if fold.start.column >= startBufferColumn
foldStartSceenColumn = fold.start.column - startBufferColumn
@@ -149,18 +154,26 @@ class Renderer
break
prefix = line.splitAt(foldStartSceenColumn)[0]
placeholder = @buildFoldPlaceholder(fold)
lineFragments.push(prefix, placeholder)
startBufferRow = fold.end.row
startBufferColumn = fold.end.column
currentScreenLineLength = currentScreenLineLength + (prefix?.text.length ? 0) + foldPlaceholderLength
suffix = recursiveBuildLinesForBufferRows(fold.end.row, endBufferRow, fold.end.column, currentScreenLineLength)
return _.compact _.flatten [prefix, placeholder, suffix]
continueMainLoop = true
break
continue if continueMainLoop
if wrapScreenColumn?
line = line.splitAt(wrapScreenColumn)[0]
line.screenDelta = new Point(1, 0)
[line].concat recursiveBuildLinesForBufferRows(startBufferRow, endBufferRow, startBufferColumn + wrapScreenColumn)
startBufferColumn += wrapScreenColumn
else
[line].concat recursiveBuildLinesForBufferRows(startBufferRow + 1, endBufferRow)
startBufferRow++
startBufferColumn = null
recursiveBuildLinesForBufferRows(@foldStartRowForBufferRow(startBufferRow), endBufferRow)
lineFragments.push(line)
currentScreenLineLength = 0
lineFragments
foldStartRowForBufferRow: (bufferRow) ->
@bufferRowForScreenRow(@screenRowForBufferRow(bufferRow))