From 148180addabb34928cc61d223b47323d89f5af46 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Fri, 20 Jun 2014 11:30:23 -0700 Subject: [PATCH] Implement select page up/down in Editor --- src/editor-component.coffee | 4 ++-- src/editor.coffee | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/editor-component.coffee b/src/editor-component.coffee index 0aafda58a..66c31f096 100644 --- a/src/editor-component.coffee +++ b/src/editor-component.coffee @@ -380,8 +380,8 @@ EditorComponent = React.createClass 'core:select-down': => editor.selectDown() 'core:select-to-top': => editor.selectToTop() 'core:select-to-bottom': => editor.selectToBottom() - 'core:select-page-up': => editor.selectUp(@getPageRows()) - 'core:select-page-down': => editor.selectDown(@getPageRows()) + 'core:select-page-up': => editor.selectPageUp() + 'core:select-page-down': => editor.selectPageDown() 'editor:indent': => editor.indent() 'editor:auto-indent': => editor.autoIndentSelectedRows() 'editor:indent-selected-rows': => editor.indentSelectedRows() diff --git a/src/editor.coffee b/src/editor.coffee index f0df41850..4f9161557 100644 --- a/src/editor.coffee +++ b/src/editor.coffee @@ -1589,6 +1589,12 @@ class Editor extends Model @moveCursorDown(@getRowsPerPage()) @setScrollTop(newScrollTop) + selectPageUp: -> + @selectUp(@getRowsPerPage()) + + selectPageDown: -> + @selectDown(@getRowsPerPage()) + # Returns the number of rows per page getRowsPerPage: -> Math.max(1, Math.ceil(@getHeight() / @getLineHeightInPixels()))