github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Only free elements that the DOMElementPool created

Browse Source
This commit is contained in:
Nathan Sobo
2017-02-13 10:46:37 -07:00
committed by Antonio Scandurra
parent 5753b75f09
commit 1528561c9b
2 changed files with 30 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
spec/dom-element-pool-spec.js
View File

@@ -51,29 +51,44 @@ describe('DOMElementPool', function () {
expect(domElementPool.buildElement('div')).not.toBe(div)
})
it('does not attempt to free nodes that were not created by the pool', () => {
let assertionFailure
atom.onDidFailAssertion((error) => assertionFailure = error)
const foreignDiv = document.createElement('div')
const div = domElementPool.buildElement('div')
div.appendChild(foreignDiv)
domElementPool.freeElementAndDescendants(div)
const span = domElementPool.buildElement('span')
span.appendChild(foreignDiv)
domElementPool.freeElementAndDescendants(span)
expect(assertionFailure).toBeUndefined()
})
it('fails an assertion when freeing the same element twice', function () {
let failure
atom.onDidFailAssertion((error) => failure = error)
let assertionFailure
atom.onDidFailAssertion((error) => assertionFailure = error)
const div = domElementPool.buildElement('div')
div.textContent = 'testing'
domElementPool.freeElementAndDescendants(div)
expect(failure).toBeUndefined()
expect(assertionFailure).toBeUndefined()
domElementPool.freeElementAndDescendants(div)
expect(failure.message).toBe('Assertion failed: The element has already been freed!')
expect(failure.metadata.content).toBe('<div>testing</div>')
expect(assertionFailure.message).toBe('Assertion failed: The element has already been freed!')
expect(assertionFailure.metadata.content).toBe('<div>testing</div>')
})
it('fails an assertion when freeing the same text node twice', function () {
let failure
atom.onDidFailAssertion((error) => failure = error)
let assertionFailure
atom.onDidFailAssertion((error) => assertionFailure = error)
const node = domElementPool.buildText('testing')
domElementPool.freeElementAndDescendants(node)
expect(failure).toBeUndefined()
expect(assertionFailure).toBeUndefined()
domElementPool.freeElementAndDescendants(node)
expect(failure.message).toBe('Assertion failed: The element has already been freed!')
expect(failure.metadata.content).toBe('testing')
expect(assertionFailure.message).toBe('Assertion failed: The element has already been freed!')
expect(assertionFailure.metadata.content).toBe('testing')
})
it('throws an error when trying to free an invalid element', function () {