From 1850da70e30d656ce0778adf314238362a22db1f Mon Sep 17 00:00:00 2001 From: Corey Johnson Date: Wed, 7 Nov 2012 15:45:37 -0800 Subject: [PATCH] Ensure closing the application will call window.shutdown on each window. --- native/atom_application.mm | 6 ++---- native/atom_window_controller.mm | 3 ++- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/native/atom_application.mm b/native/atom_application.mm index 316be6323..869bddcfa 100644 --- a/native/atom_application.mm +++ b/native/atom_application.mm @@ -171,10 +171,8 @@ } - (void)applicationWillTerminate:(NSNotification *)notification { - NSInteger windowCount = [[self windows] count]; - for(int i = 0; i < windowCount; i++) { - NSWindow *window = [[self windows] objectAtIndex:i]; - [window performClose:0]; + for (NSWindow *window in [self windows]) { + [window performClose:self]; } CefShutdown(); } diff --git a/native/atom_window_controller.mm b/native/atom_window_controller.mm index fcb4fcead..4a259f0fe 100644 --- a/native/atom_window_controller.mm +++ b/native/atom_window_controller.mm @@ -164,11 +164,12 @@ } } -- (void)windowWillClose:(NSNotification *)notification { +- (BOOL)windowShouldClose:(NSNotification *)notification { if (_cefClient && _cefClient->GetBrowser()) { _cefClient->GetBrowser()->SendProcessMessage(PID_RENDERER, CefProcessMessage::Create("shutdown")); } [self autorelease]; + return YES; } - (void)populateBrowserSettings:(CefBrowserSettings &)settings {