github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make cursor blink by changing CSS visibility with setInterval

Browse Source 
This is actually more efficient than the CSS animation we were doing previously, because it doesn't force the cursor to be sampled at 60 FPS for something that changes around twice a second.
This commit is contained in:
Nathan Sobo
2012-11-14 20:43:34 -07:00
parent 5dea68bb4c
commit 185ca22488
3 changed files with 35 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/app/editor-spec.coffee
View File

@@ -935,11 +935,11 @@ describe "Editor", ->
editor.setSelectedBufferRange([[0, 0], [3, 0]])
expect(editor.getSelection().isEmpty()).toBeFalsy()
expect(cursorView).not.toBeVisible()
expect(cursorView.css('visibility')).toBe 'hidden'
editor.setCursorBufferPosition([1, 3])
expect(editor.getSelection().isEmpty()).toBeTruthy()
expect(cursorView).toBeVisible()
expect(cursorView.css('visibility')).toBe 'visible'
describe "auto-scrolling", ->
it "only auto-scrolls when the last cursor is moved", ->
@@ -1794,10 +1794,10 @@ describe "Editor", ->
editor.setCursorScreenPosition([2,0])
expect(editor.lineElementForScreenRow(2)).toMatchSelector('.fold.selected')
expect(editor.find('.cursor').css('display')).toBe 'none'
expect(editor.find('.cursor').css('visibility')).toBe 'hidden'
editor.setCursorScreenPosition([3,0])
expect(editor.find('.cursor').css('display')).toBe 'block'
expect(editor.find('.cursor').css('visibility')).toBe 'visible'
describe "when a selected fold is scrolled into view (and the fold line was not previously rendered)", ->
it "renders the fold's line element with the 'selected' class", ->