github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-07 05:05:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

🐎 Avoid building unnecessary scope chains

Browse Source
This commit is contained in:
Max Brunsfeld
2016-07-11 13:51:08 -07:00
parent f327a4f95d
commit 1ecc61bebf
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/scope-descriptor.coffee
View File

@@ -47,3 +47,11 @@ class ScopeDescriptor
toString: ->
@getScopeChain()
isEqual: (other) ->
if @scopes.length isnt other.scopes.length
return false
for scope, i in @scopes
if scope isnt other.scopes[i]
return false
true

4
src/text-editor-registry.js
View File

@@ -116,7 +116,7 @@ export default class TextEditorRegistry {
this.subscriptions.add(
this.config.onDidChange(settingKey, configOptions, ({newValue}) => {
this.editorsWithMaintainedConfig.forEach(editor => {
if (editor.getRootScopeDescriptor().getScopeChain() === scopeChain) {
if (editor.getRootScopeDescriptor().isEqual(scopeDescriptor)) {
editor[setterName](newValue)
}
})
@@ -129,7 +129,7 @@ export default class TextEditorRegistry {
const softTabs = this.config.get('editor.softTabs', configOptions)
this.editorsWithMaintainedConfig.forEach(editor => {
if (editor.getRootScopeDescriptor().getScopeChain() === scopeChain) {
if (editor.getRootScopeDescriptor().isEqual(scopeDescriptor)) {
editor.setSoftTabs(shouldEditorUseSoftTabs(editor, tabType, softTabs))
}
})