From 24f9c24d79a8d7911901422c83405bb14a3ed4ea Mon Sep 17 00:00:00 2001 From: Antonio Scandurra Date: Tue, 20 Sep 2016 15:29:31 +0200 Subject: [PATCH] :bug: Perform measurements only when editor is visible --- src/text-editor-component.coffee | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/text-editor-component.coffee b/src/text-editor-component.coffee index ca1017617..6780bd404 100644 --- a/src/text-editor-component.coffee +++ b/src/text-editor-component.coffee @@ -195,6 +195,9 @@ class TextEditorComponent becameVisible: -> @updatesPaused = true + if @invalidateMeasurementsWhenVisible + @invalidateMeasurements() + @invalidateMeasurementsWhenVisible = false @measureScrollbars() if @measureScrollbarsWhenShown @sampleFontStyling() @sampleBackgroundColors() @@ -934,8 +937,11 @@ class TextEditorComponent @invalidateMeasurements() invalidateMeasurements: -> - @linesYardstick.invalidateCache() - @presenter.measurementsChanged() + if @isVisible() + @linesYardstick.invalidateCache() + @presenter.measurementsChanged() + else + @invalidateMeasurementsWhenVisible = true screenPositionForMouseEvent: (event, linesClientRect) -> pixelPosition = @pixelPositionForMouseEvent(event, linesClientRect)