From 2944b64795da85a59646d9795ddf44f9fd56fa76 Mon Sep 17 00:00:00 2001 From: Corey Johnson Date: Mon, 25 Mar 2013 14:59:29 -0700 Subject: [PATCH] Show GitHub API error message when markdown preview fails --- .../lib/markdown-preview-view.coffee | 21 ++++++++++++------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/packages/markdown-preview/lib/markdown-preview-view.coffee b/src/packages/markdown-preview/lib/markdown-preview-view.coffee index 5b88545ac..62a832e5c 100644 --- a/src/packages/markdown-preview/lib/markdown-preview-view.coffee +++ b/src/packages/markdown-preview/lib/markdown-preview-view.coffee @@ -32,15 +32,20 @@ class MarkdownPreviewView extends ScrollView getPath: -> @buffer.getPath() - setErrorHtml: -> + setErrorHtml: (result)-> + try failureMessage = JSON.parse(result.responseText).message + @html $$$ -> @h2 'Previewing Markdown Failed' - @h3 'Possible Reasons' - @ul => - @li => - @span 'You aren\'t online or are unable to reach ' - @a 'github.com', href: 'https://github.com' - @span '.' + if failureMessage? + @h3 failureMessage + else + @h3 'Possible Reasons' + @ul => + @li => + @span 'You aren\'t online or are unable to reach ' + @a 'github.com', href: 'https://github.com' + @span '.' setLoading: -> @html($$$ -> @div class: 'markdown-spinner', 'Loading Markdown...') @@ -56,4 +61,4 @@ class MarkdownPreviewView extends ScrollView mode: 'markdown' text: @buffer.getText() success: (html) => @html(html) - error: => @setErrorHtml() + error: (result) => @setErrorHtml(result)