From 0aa4c1a976443abc97caf8d288fac2491d73b703 Mon Sep 17 00:00:00 2001 From: Matthew Dapena-Tretter Date: Fri, 12 May 2017 13:50:19 -0700 Subject: [PATCH] Pane shouldn't steal focus from its children This was removed in #14175 in order to solve #14173 (editors not being focused when clicking tabs). However, it means that the pane steals focus from its children. The solution is to add the guard back and to solve #14173 in another way: by delaying the activation of the item (see atom/tabs#439). --- src/pane-element.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pane-element.coffee b/src/pane-element.coffee index 2b8260db6..8d2952880 100644 --- a/src/pane-element.coffee +++ b/src/pane-element.coffee @@ -67,7 +67,7 @@ class PaneElement extends HTMLElement activated: -> @isActivating = true - @focus() + @focus() unless @hasFocus() # Don't steal focus from children. @isActivating = false activeStatusChanged: (active) ->