Specs for positioning the overlay decorations

This commit is contained in:
Ben Ogle
2014-11-11 13:08:05 -08:00
parent 0bb173b646
commit 307108ec6c
2 changed files with 31 additions and 10 deletions

View File

@@ -9,7 +9,7 @@ class OverlayManager
existingDecorations = null
for markerId, {startPixelPosition, endPixelPosition, decorations} of overlayDecorations
for decoration in decorations
@renderOverlay(hostElement, decoration, endPixelPosition)
@renderOverlay(hostElement, decoration, endPixelPosition, lineHeightInPixels)
existingDecorations ?= {}
existingDecorations[decoration.id] = true
@@ -21,11 +21,11 @@ class OverlayManager
return
renderOverlay: (hostElement, decoration, endPixelPosition) ->
renderOverlay: (hostElement, decoration, pixelPosition, lineHeightInPixels) ->
unless overlay = @overlays[decoration.id]
overlay = @overlays[decoration.id] = document.createElement('atom-overlay')
overlay.appendChild(atom.views.getView(decoration.item))
hostElement.appendChild(overlay)
overlay.style.top = endPixelPosition.top + 'px'
overlay.style.left = endPixelPosition.left + 'px'
overlay.style.top = pixelPosition.top + lineHeightInPixels + 'px'
overlay.style.left = pixelPosition.left + 'px'