github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-10 22:55:09 -05:00
Code Issues Packages Projects Releases Wiki Activity

Convert FileFinder to a proper extension and remove references from RootView code

Browse Source
This commit is contained in:
Nathan Sobo
2012-05-07 19:30:07 -06:00
parent 81b7105a52
commit 31163f1d8c
8 changed files with 132 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/app/project-spec.coffee
View File

@@ -39,14 +39,6 @@ describe "Project", ->
expect(buffer.path).toBeUndefined()
expect(newBufferHandler).toHaveBeenCalledWith(buffer)
describe ".getFilePaths()", ->
it "returns a promise which resolves to a list of all file paths in the project, recursively", ->
expectedPaths = (path.replace(project.path, '') for path in fs.listTree(project.path) when fs.isFile path)
waitsForPromise ->
project.getFilePaths().done (result) ->
expect(result).toEqual(expectedPaths)
describe ".resolve(path)", ->
it "returns an absolute path based on the project's root", ->
absolutePath = require.resolve('fixtures/dir/a')

61
spec/app/root-view-spec.coffee
View File

@@ -341,67 +341,6 @@ describe "RootView", ->
rootView.deactivate()
expect(extension.deactivate).toHaveBeenCalled()
describe "the file finder", ->
describe "when the toggle-file-finder event is triggered", ->
describe "when there is a project", ->
it "shows the FileFinder when it is not on screen and hides it when it is", ->
rootView.attachToDom()
expect(rootView.find('.file-finder')).not.toExist()
rootView.find('.editor').trigger 'split-right'
[editor1, editor2] = rootView.find('.editor').map -> $(this).view()
rootView.trigger 'toggle-file-finder'
expect(rootView.find('.file-finder')).toExist()
expect(rootView.find('.file-finder input:focus')).toExist()
rootView.trigger 'toggle-file-finder'
expect(editor1.isFocused).toBeFalsy()
expect(editor2.isFocused).toBeTruthy()
expect(rootView.find('.editor:has(:focus)')).toExist()
expect(rootView.find('.file-finder')).not.toExist()
it "shows all relative file paths for the current project", ->
rootView.trigger 'toggle-file-finder'
project.getFilePaths().done (paths) ->
expect(rootView.fileFinder.pathList.children('li').length).toBe paths.length
for path in paths
relativePath = project.relativize(path)
expect(rootView.fileFinder.pathList.find("li:contains(#{relativePath}):not(:contains(#{project.path}))")).toExist()
describe "when there is no project", ->
beforeEach ->
rootView = new RootView
it "does not open the FileFinder", ->
expect(rootView.activeEditor().buffer.path).toBeUndefined()
expect(rootView.find('.file-finder')).not.toExist()
rootView.trigger 'toggle-file-finder'
expect(rootView.find('.file-finder')).not.toExist()
describe "when a path is selected in the file finder", ->
it "opens the file associated with that path in the editor", ->
rootView.attachToDom()
rootView.find('.editor').trigger 'split-right'
[editor1, editor2] = rootView.find('.editor').map -> $(this).view()
rootView.trigger 'toggle-file-finder'
rootView.fileFinder.trigger 'move-down'
selectedLi = rootView.fileFinder.find('li:eq(1)')
expectedPath = fs.join(project.path, selectedLi.text())
expect(editor1.buffer.path).not.toBe expectedPath
expect(editor2.buffer.path).not.toBe expectedPath
rootView.fileFinder.trigger 'file-finder:select-file'
expect(editor1.buffer.path).not.toBe expectedPath
expect(editor2.buffer.path).toBe expectedPath
expect(editor2.isFocused).toBeTruthy()
describe "keymap wiring", ->
commandHandler = null
beforeEach ->