From 317428b58df1e4ef706897e2ffb86920510668df Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Thu, 6 Apr 2017 12:52:42 -0600 Subject: [PATCH] Inform pane containers directly when adding non-moved pane items --- src/pane-container.js | 12 +++--------- src/pane.coffee | 2 ++ 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/pane-container.js b/src/pane-container.js index 0d9806cc6..d74c7a6a4 100644 --- a/src/pane-container.js +++ b/src/pane-container.js @@ -306,22 +306,16 @@ class PaneContainer { const iterable = pane.getItems() for (let index = 0; index < iterable.length; index++) { const item = iterable[index] - this.addedPaneItem(item, pane, index) + this.didAddPaneItem(item, pane, index) } - pane.onDidAddItem(({item, index, moved}) => { - if (!moved) { this.addedPaneItem(item, pane, index) } - } - ) - pane.onDidRemoveItem(({item, moved}) => { if (!moved) { this.removedPaneItem(item) } - } - ) + }) })) } - addedPaneItem (item, pane, index) { + didAddPaneItem (item, pane, index) { this.itemRegistry.addItem(item) this.emitter.emit('did-add-pane-item', {item, pane, index}) } diff --git a/src/pane.coffee b/src/pane.coffee index 92e4f7c3c..4adbccc4c 100644 --- a/src/pane.coffee +++ b/src/pane.coffee @@ -500,6 +500,8 @@ class Pane @setPendingItem(item) if pending @emitter.emit 'did-add-item', {item, index, moved} + @container?.didAddPaneItem(item, this, index) unless moved + @destroyItem(lastPendingItem) if replacingPendingItem @setActiveItem(item) unless @getActiveItem()? item