github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #20892 from robobenklein/robo/texteditorcomponent-preventscroll

Browse Source 
Use HTML native preventScroll for textEditorComponent focus
This commit is contained in:
Sadick
2020-10-19 21:31:38 +03:00
committed by GitHub
parent 44c1b24f6c 6402f02c31
commit 320c8796fc
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/text-editor-component.js
View File

@@ -1673,7 +1673,7 @@ module.exports = class TextEditorComponent {
this.scheduleUpdate();
}
this.getHiddenInput().focus();
this.getHiddenInput().focus({preventScroll:true});
}
// Called by TextEditorElement so that this function is always the first
@@ -1698,12 +1698,6 @@ module.exports = class TextEditorComponent {
}
didFocusHiddenInput() {
// Focusing the hidden input when it is off-screen causes the browser to
// scroll it into view. Since we use synthetic scrolling this behavior
// causes all the lines to disappear so we counteract it by always setting
// the scroll position to 0.
this.refs.scrollContainer.scrollTop = 0;
this.refs.scrollContainer.scrollLeft = 0;
if (!this.focused) {
this.focused = true;
this.startCursorBlinking();
@@ -1932,7 +1926,7 @@ module.exports = class TextEditorComponent {
// Disabling the hidden input makes it lose focus as well, so we have to
// re-enable and re-focus it.
this.getHiddenInput().disabled = false;
this.getHiddenInput().focus();
this.getHiddenInput().focus({preventScroll:true});
});
return;
}