From 37e471b3156bc3b6d6b2c8b82ac149d33ad458a3 Mon Sep 17 00:00:00 2001 From: Ash Wilson Date: Fri, 19 Apr 2019 12:05:16 -0400 Subject: [PATCH] Omit missing windows from the shorthand assertion summary --- spec/main-process/atom-application.new.test.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/spec/main-process/atom-application.new.test.js b/spec/main-process/atom-application.new.test.js index 02b900c94..47343ca33 100644 --- a/spec/main-process/atom-application.new.test.js +++ b/spec/main-process/atom-application.new.test.js @@ -832,17 +832,19 @@ class LaunchScenario { missingRoots: spec.roots, extraEditors: [], missingEditors: spec.editors, - roots: [], - editors: [] + roots: null, + editors: null }) } const shorthandParts = [] const descriptionParts = [] for (const comparison of comparisons) { - const shortRoots = Array.from(comparison.roots, r => path.basename(r)).join(',') - const shortPaths = Array.from(comparison.editors, e => path.basename(e)).join(',') - shorthandParts.push(`[${shortRoots} ${shortPaths}]`) + if (comparison.roots !== null && comparison.editors !== null) { + const shortRoots = Array.from(comparison.roots, r => path.basename(r)).join(',') + const shortPaths = Array.from(comparison.editors, e => path.basename(e)).join(',') + shorthandParts.push(`[${shortRoots} ${shortPaths}]`) + } if (comparison.ok) { continue