From 397afdeca0dabfea554d844fca3bb9355da83f8d Mon Sep 17 00:00:00 2001 From: Mazen El-Kashef Date: Tue, 19 May 2020 23:37:57 -0500 Subject: [PATCH] Fix node versioin --- script/package.json | 2 +- script/vsts/nightly-release.yml | 4 ++-- script/vsts/platforms/linux.yml | 4 ++-- script/vsts/platforms/macos.yml | 12 ++++++------ script/vsts/platforms/windows.yml | 6 +++--- script/vsts/release-branch-build.yml | 4 ++-- script/vsts/windows-run.js | 2 +- 7 files changed, 17 insertions(+), 17 deletions(-) diff --git a/script/package.json b/script/package.json index f8e7d0646..e9e3ad96e 100644 --- a/script/package.json +++ b/script/package.json @@ -11,7 +11,7 @@ "colors": "1.1.2", "donna": "1.0.16", "electron-chromedriver": "^6.0.0", - "electron-link": "0.4.2", + "electron-link": "^0.4.2", "electron-mksnapshot": "^6.0.0", "electron-packager": "^14.2.1", "@atom/electron-winstaller": "0.0.1", diff --git a/script/vsts/nightly-release.yml b/script/vsts/nightly-release.yml index a5049f2bf..8dfc00bc6 100644 --- a/script/vsts/nightly-release.yml +++ b/script/vsts/nightly-release.yml @@ -32,8 +32,8 @@ jobs: steps: - task: NodeTool@0 inputs: - versionSpec: 12.14.0 - displayName: Install Node.js 12.14.0 + versionSpec: 12.4.0 + displayName: Install Node.js 12.4.0 #This has to be done separately because VSTS inexplicably #exits the script block after `npm install` completes. diff --git a/script/vsts/platforms/linux.yml b/script/vsts/platforms/linux.yml index c1714f5b0..0717daf07 100644 --- a/script/vsts/platforms/linux.yml +++ b/script/vsts/platforms/linux.yml @@ -24,8 +24,8 @@ jobs: - task: NodeTool@0 inputs: - versionSpec: 12.14.0 - displayName: Install Node.js 12.14.0 + versionSpec: 12.4.0 + displayName: Install Node.js 12.4.0 - script: npm install --global npm@6.13.4 displayName: Update npm diff --git a/script/vsts/platforms/macos.yml b/script/vsts/platforms/macos.yml index 888cb9c47..28983fc74 100644 --- a/script/vsts/platforms/macos.yml +++ b/script/vsts/platforms/macos.yml @@ -14,8 +14,8 @@ jobs: steps: - task: NodeTool@0 inputs: - versionSpec: 12.14.0 - displayName: Install Node.js 12.14.0 + versionSpec: 12.4.0 + displayName: Install Node.js 12.4.0 #- task: 1ESLighthouseEng.PipelineArtifactCaching.RestoreCacheV1.RestoreCache@1 # displayName: Restore node_modules cache @@ -29,7 +29,7 @@ jobs: env: CI: true CI_PROVIDER: VSTS - NPM_BIN_PATH: /Users/runner/hostedtoolcache/node/12.14.0/x64/bin/npm + NPM_BIN_PATH: /Users/runner/hostedtoolcache/node/12.4.0/x64/bin/npm npm_config_build_from_source: true condition: ne(variables['CacheRestored'], 'true') @@ -112,8 +112,8 @@ jobs: steps: - task: NodeTool@0 inputs: - versionSpec: 12.14.0 - displayName: Install Node.js 12.14.0 + versionSpec: 12.4.0 + displayName: Install Node.js 12.4.0 - task: 1ESLighthouseEng.PipelineArtifactCaching.RestoreCacheV1.RestoreCache@1 displayName: Restore node_modules cache @@ -129,7 +129,7 @@ jobs: env: CI: true CI_PROVIDER: VSTS - NPM_BIN_PATH: /Users/runner/hostedtoolcache/node/12.14.0/x64/bin/npm + NPM_BIN_PATH: /Users/runner/hostedtoolcache/node/12.4.0/x64/bin/npm npm_config_build_from_source: true condition: ne(variables['CacheRestored'], 'true') diff --git a/script/vsts/platforms/windows.yml b/script/vsts/platforms/windows.yml index 1c0769025..2f6f31d41 100644 --- a/script/vsts/platforms/windows.yml +++ b/script/vsts/platforms/windows.yml @@ -26,8 +26,8 @@ jobs: - task: NodeTool@0 inputs: - versionSpec: 12.14.0 - displayName: Install Node.js 12.14.0 + versionSpec: 12.4.0 + displayName: Install Node.js 12.4.0 - script: | ECHO Installing npm-windows-upgrade @@ -70,7 +70,7 @@ jobs: BUILD_ARCH: $(buildArch) CI: true CI_PROVIDER: VSTS - NPM_BIN_PATH: "C:\\hostedtoolcache\\windows\\node\\12.14.0\\x64\\npm.cmd" + NPM_BIN_PATH: "C:\\hostedtoolcache\\windows\\node\\12.4.0\\x64\\npm.cmd" npm_config_build_from_source: true displayName: Bootstrap build environment condition: ne(variables['CacheRestored'], 'true') diff --git a/script/vsts/release-branch-build.yml b/script/vsts/release-branch-build.yml index 1a12038f5..69bffeae5 100644 --- a/script/vsts/release-branch-build.yml +++ b/script/vsts/release-branch-build.yml @@ -38,8 +38,8 @@ jobs: steps: - task: NodeTool@0 inputs: - versionSpec: 12.14.0 - displayName: Install Node.js 12.14.0 + versionSpec: 12.4.0 + displayName: Install Node.js 12.4.0 # This has to be done separately because VSTS inexplicably # exits the script block after `npm install` completes. diff --git a/script/vsts/windows-run.js b/script/vsts/windows-run.js index 3573001b8..ef63cc6f1 100644 --- a/script/vsts/windows-run.js +++ b/script/vsts/windows-run.js @@ -5,7 +5,7 @@ const path = require('path'); const download = require('download'); const childProcess = require('child_process'); -const nodeVersion = '12.14.0'; +const nodeVersion = '12.4.0'; const nodeFileName = `node-v${nodeVersion}-win-x86`; const extractedNodePath = `c:\\tmp\\${nodeFileName}`;