Add atom.showDevTools and replace calls to $native.showDevTools

native/atom_cef_client.cpp

@@ -35,6 +35,9 @@ bool AtomCefClient::OnProcessMessageReceived(CefRefPtr<CefBrowser> browser,
   else if (name == "toggleDevTools") {
     ToggleDevTools(browser);
   }
+  else if (name == "showDevTools") {
+    ShowDevTools(browser);
+  }
   else if (name == "confirm") {
     std::string message = argumentList->GetString(1).ToString();
     std::string detailedMessage = argumentList->GetString(2).ToString();

native/atom_cef_client.h

@@ -99,12 +99,13 @@ class AtomCefClient : public CefClient,
   void Open(std::string path);
   void Open();
   void NewWindow();
+  void ToggleDevTools(CefRefPtr<CefBrowser> browser);
+  void ShowDevTools(CefRefPtr<CefBrowser> browser);
   void Confirm(int replyId,
                std::string message,
                std::string detailedMessage,
                std::vector<std::string> buttonLabels,
                CefRefPtr<CefBrowser> browser);
-  void ToggleDevTools(CefRefPtr<CefBrowser> browser);
   void ShowSaveDialog(int replyId, CefRefPtr<CefBrowser> browser);
   CefRefPtr<CefListValue> CreateReplyDescriptor(int replyId, int callbackIndex);
 

native/atom_cef_client_mac.mm

@@ -52,6 +52,11 @@ void AtomCefClient::ToggleDevTools(CefRefPtr<CefBrowser> browser) {
   [windowController toggleDevTools];
 }
 
+void AtomCefClient::ShowDevTools(CefRefPtr<CefBrowser> browser) {
+  AtomWindowController *windowController = [[browser->GetHost()->GetWindowHandle() window] windowController];
+  [windowController showDevTools];
+}
+
 void AtomCefClient::ShowSaveDialog(int replyId, CefRefPtr<CefBrowser> browser) {
   CefRefPtr<CefProcessMessage> replyMessage = CefProcessMessage::Create("reply");
   CefRefPtr<CefListValue> replyArguments = replyMessage->GetArgumentList();

native/atom_window_controller.h

@@ -26,5 +26,6 @@ class AtomCefClient;
 - (id)initBenchmarks;
 
 - (void)toggleDevTools;
+- (void)showDevTools;
 
 @end

native/atom_window_controller.mm

@@ -80,6 +80,8 @@
 }
 
 - (void)showDevTools {
+  if (_devToolsView) return;
+
   if (_cefClient && _cefClient->GetBrowser()) {
     _devToolsView = [[NSView alloc] initWithFrame:_splitView.bounds];
     [_splitView addSubview:_devToolsView];