From 188b2e5a74e87ae98c1ce70986848d74d637ce03 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Mon, 6 Apr 2015 15:55:51 -0700 Subject: [PATCH 1/4] Report core deprecations in specs --- spec/spec-helper.coffee | 1 - 1 file changed, 1 deletion(-) diff --git a/spec/spec-helper.coffee b/spec/spec-helper.coffee index 5406ff33a..70fb4fb58 100644 --- a/spec/spec-helper.coffee +++ b/spec/spec-helper.coffee @@ -72,7 +72,6 @@ if specDirectory isCoreSpec = specDirectory == fs.realpathSync(__dirname) beforeEach -> - Grim.clearDeprecations() if isCoreSpec $.fx.off = true documentTitle = null projectPath = specProjectPath ? path.join(@specDirectory, 'fixtures') From 50d9fee0d3ce00b6a1bbfe8a2f7a4249956d14f7 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Mon, 6 Apr 2015 16:21:09 -0700 Subject: [PATCH 2/4] Use Project::onDidAddBuffer --- spec/project-spec.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/project-spec.coffee b/spec/project-spec.coffee index a1cdce662..703b3d4f8 100644 --- a/spec/project-spec.coffee +++ b/spec/project-spec.coffee @@ -221,7 +221,7 @@ describe "Project", -> beforeEach -> absolutePath = require.resolve('./fixtures/dir/a') newBufferHandler = jasmine.createSpy('newBufferHandler') - atom.project.on 'buffer-created', newBufferHandler + atom.project.onDidAddBuffer(newBufferHandler) describe "when given an absolute path that isn't currently open", -> it "returns a new edit session for the given path and emits 'buffer-created'", -> From 9b7870d5032607b6bd357c49cdf3feaa5cdb4154 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Mon, 6 Apr 2015 16:22:31 -0700 Subject: [PATCH 3/4] Snapshot deprecations around calls to Project::eachBuffer --- spec/project-spec.coffee | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/spec/project-spec.coffee b/spec/project-spec.coffee index 703b3d4f8..d89802243 100644 --- a/spec/project-spec.coffee +++ b/spec/project-spec.coffee @@ -502,8 +502,12 @@ describe "Project", -> describe ".eachBuffer(callback)", -> beforeEach -> + jasmine.snapshotDeprecations() atom.project.bufferForPathSync('a') + afterEach -> + jasmine.restoreDeprecationsSnapshot() + it "invokes the callback for existing buffer", -> count = 0 count = 0 From e02e8c91a6ce97b9a9d348ef297b27256203a700 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Mon, 6 Apr 2015 16:29:12 -0700 Subject: [PATCH 4/4] Use TextEditor::onDidChangeCursorPosition in spec --- spec/text-editor-component-spec.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/text-editor-component-spec.coffee b/spec/text-editor-component-spec.coffee index a5ca4c309..b2ef2ec51 100644 --- a/spec/text-editor-component-spec.coffee +++ b/spec/text-editor-component-spec.coffee @@ -728,7 +728,7 @@ describe "TextEditorComponent", -> expect(cursorNodes[0].style['-webkit-transform']).toBe "translate(#{10 * charWidth}px, #{4 * lineHeightInPixels}px)" expect(cursorNodes[1].style['-webkit-transform']).toBe "translate(#{11 * charWidth}px, #{8 * lineHeightInPixels}px)" - wrapperView.on 'cursor:moved', cursorMovedListener = jasmine.createSpy('cursorMovedListener') + editor.onDidChangeCursorPosition cursorMovedListener = jasmine.createSpy('cursorMovedListener') cursor3.setScreenPosition([4, 11], autoscroll: false) nextAnimationFrame() expect(cursorNodes[0].style['-webkit-transform']).toBe "translate(#{11 * charWidth}px, #{4 * lineHeightInPixels}px)"