From 3ff0b3cfe216381e8f97f2e88eef19d9d3e12375 Mon Sep 17 00:00:00 2001
From: Kevin Sawicki <kevin@github.com>
Date: Fri, 11 Oct 2013 11:47:06 -0700
Subject: [PATCH] Fail build when either set of specs fail

---
 tasks/spec-task.coffee | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tasks/spec-task.coffee b/tasks/spec-task.coffee
index 56281cdbe..39af97f6e 100644
--- a/tasks/spec-task.coffee
+++ b/tasks/spec-task.coffee
@@ -34,7 +34,7 @@ module.exports = (grunt) ->
       queue.push(packagePath)
 
     queue.concurrency = 1
-    queue.drain = -> callback(passed)
+    queue.drain = -> callback(null, passed)
 
   runCoreSpecs = (callback) ->
     contentsDir = grunt.config.get('atom.contentsDir')
@@ -46,8 +46,10 @@ module.exports = (grunt) ->
       cmd: appPath
       args: ['--test', "--resource-path=#{resourcePath}", "--spec-directory=#{coreSpecsPath}"]
     spawn options, (error, results, code) ->
-      callback(code is 0)
+      callback(null, code is 0)
 
   grunt.registerTask 'run-specs', 'Run the specs', ->
-    passed = true
-    async.parallel([runCoreSpecs, runPackageSpecs], @async())
+    done = @async()
+    async.parallel [runCoreSpecs, runPackageSpecs], (error, results) ->
+      [coreSpecPassed, packageSpecsPassed] = results
+      done(coreSpecPassed and packageSpecsPassed)