From 45bd466384930dbc9a126bfd91f655456629afce Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Tue, 28 Mar 2017 15:00:13 -0600 Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20add=20item=20in=20Workspace.ope?= =?UTF-8?q?n=20if=20activateItem=20is=20false?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We thought it was a bug that activateItem: false caused the item not to be added, but it turned out there were package tests that depended on this behavior. Ideally, we should have an addItem option that exhibits this behavior instead. Signed-off-by: Max Brunsfeld --- src/workspace.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/workspace.js b/src/workspace.js index 1a1786bbc..8d346e9bd 100644 --- a/src/workspace.js +++ b/src/workspace.js @@ -712,7 +712,6 @@ module.exports = class Workspace extends Model { pane.clearPendingItem() } - pane.addItem(item, options) this.itemOpened(item) if (options.activateItem !== false) {