github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-09 06:05:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Ensure that evil filenames do not hose Project.scan

Browse Source
This commit is contained in:
Corey Johnson & Nathan Sobo
2012-07-18 16:22:21 -06:00
parent 12a576ff95
commit 4b1403724b
7 changed files with 23 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/app/project.coffee
View File

@@ -138,13 +138,13 @@ class Project
scan: (regex, iterator) ->
regex = new RegExp(regex.source, 'g')
commands = [
"find \"#{@getPath()}\" -type f"
"grep --perl-regexp --invert-match --regexp=\"#{@ignorePathRegex()}\""
"xargs grep --null --perl-regexp --with-filename --line-number --recursive --regexp=\"#{regex.source}\""
]
command = [
"find \"#{@getPath()}\" -type f -print0" # find all paths in the project's working directory
"grep --text --perl-regexp --invert-match --regexp=\"#{@ignorePathRegex()}\"" # accept only non-ignored paths, separated by \0 (find doesn't support pcre)
"perl -0pi -e 's/\n$//'" # delete grep's trailing newline because it screws up xargs
"xargs -0 grep --null --perl-regexp --with-filename --line-number --recursive --regexp=\"#{regex.source}\"" # run grep on each filtered file
].join(" | ")
command = commands.join(" | ")
ChildProcess.exec command, bufferLines: true, stdout: (data) ->
for grepLine in data.split('\n') when grepLine.length
nullCharIndex = grepLine.indexOf('\0')