From 4b867ddc7a8de99894ebf00fe633f73bc2242228 Mon Sep 17 00:00:00 2001
From: Kevin Sawicki <kevin@github.com>
Date: Thu, 4 Sep 2014 09:43:59 -0700
Subject: [PATCH] Properly delete socket file in benchmark

---
 benchmark/browser-process-startup.coffee | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/benchmark/browser-process-startup.coffee b/benchmark/browser-process-startup.coffee
index 3b83f185f..06f2a0d48 100644
--- a/benchmark/browser-process-startup.coffee
+++ b/benchmark/browser-process-startup.coffee
@@ -1,6 +1,7 @@
 #!/usr/bin/env coffee
 
 {spawn, exec} = require 'child_process'
+fs = require 'fs'
 os = require 'os'
 path = require 'path'
 _ = require 'underscore-plus'
@@ -10,24 +11,30 @@ directoryToOpen = temp.mkdirSync('browser-process-startup-')
 socketPath = path.join(os.tmpdir(), 'atom.sock')
 numberOfRuns = 10
 
+deleteSocketFile = ->
+  try
+    fs.unlinkSync(socketPath) if fs.existsSync(socketPath)
+  catch error
+    console.error(error)
+
 launchAtom = (callback) ->
+  deleteSocketFile()
+
   cmd = 'atom'
   args = ['--safe', '--new-window', '--foreground', directoryToOpen]
   atomProcess = spawn(cmd, args)
 
   output = ''
   startupTimes = []
-
   dataListener = (data) ->
     output += data
     if match = /App load time: (\d+)/.exec(output)
+      startupTime = parseInt(match[1])
       atomProcess.stderr.removeListener 'data', dataListener
       atomProcess.kill()
-      exec 'pkill -9 Atom', ->
-        try
-          fs.unlinkSync(socketPath)
-
-        callback(parseInt(match[1]))
+      exec 'pkill -9 Atom', (error) ->
+        console.error(error) if error?
+        callback(startupTime)
 
   atomProcess.stderr.on 'data', dataListener
 
@@ -41,6 +48,7 @@ collector = (startupTime) ->
     minTime = _.min(startupTimes)
     totalTime = startupTimes.reduce (previousValue=0, currentValue) -> previousValue + currentValue
     console.log "Startup Runs: #{startupTimes.length}"
+    console.log "First run time: #{startupTimes[0]}ms"
     console.log "Max time: #{maxTime}ms"
     console.log "Min time: #{minTime}ms"
     console.log "Average time: #{Math.round(totalTime/startupTimes.length)}ms"