From 4fa24a05daf48d82360f6960d11d886ed597a0bf Mon Sep 17 00:00:00 2001 From: Max Brunsfeld Date: Thu, 15 Sep 2016 16:34:39 -0700 Subject: [PATCH] Fix invalid usage of activation disposable in Package::load Like deserializers and config schema, directory providers are added at package load time, and *not* removed when the package is deactivated --- src/package.coffee | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/package.coffee b/src/package.coffee index dc994f10d..dbc648c7f 100644 --- a/src/package.coffee +++ b/src/package.coffee @@ -298,9 +298,7 @@ class Package for version, methodName of directoryProviderService.versions if typeof @mainModule[methodName] is 'function' servicesByVersion[version] = @mainModule[methodName]() - - disposable = @packageManager.serviceHub.provide('atom.directory-provider', servicesByVersion) - @activationDisposables.add(disposable) + @packageManager.serviceHub.provide('atom.directory-provider', servicesByVersion) registerViewProviders: -> if @metadata.viewProviders? and not @registeredViewProviders