github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove ::removeItemAtIndex and make ::removeItem private

Browse Source 
Call ::destroyItem or just destroy the item directly (it should emit the
'destroyed' event)
This commit is contained in:
Nathan Sobo
2014-01-12 17:25:51 -07:00
parent 2a8a5268c6
commit 561e31c0c5
5 changed files with 38 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pane-model.coffee
View File

@@ -135,12 +135,10 @@ class PaneModel extends Model
@emit 'item-added', item, index
item
# Private:
removeItem: (item, destroying) ->
index = @items.indexOf(item)
@removeItemAtIndex(index, destroying) if index >= 0
removeItemAtIndex: (index, destroying) ->
item = @items[index]
return if index is -1
@showNextItem() if item is @activeItem and @items.length > 1
@items.splice(index, 1)
@emit 'item-removed', item, index, destroying

10
src/pane.coffee
View File

@@ -26,11 +26,11 @@ class Pane extends View
@delegatesProperties 'items', 'activeItem', toProperty: 'model'
@delegatesMethods 'getItems', 'showNextItem', 'showPreviousItem', 'getActiveItemIndex',
'showItemAtIndex', 'showItem', 'addItem', 'itemAtIndex', 'removeItem', 'removeItemAtIndex',
'moveItem', 'moveItemToPane', 'destroyItem', 'destroyItems', 'destroyActiveItem',
'destroyInactiveItems', 'saveActiveItem', 'saveActiveItemAs', 'saveItem', 'saveItemAs',
'saveItems', 'itemForUri', 'showItemForUri', 'promptToSaveItem', 'copyActiveItem',
'isActive', 'activate', toProperty: 'model'
'showItemAtIndex', 'showItem', 'addItem', 'itemAtIndex', 'moveItem', 'moveItemToPane',
'destroyItem', 'destroyItems', 'destroyActiveItem', 'destroyInactiveItems',
'saveActiveItem', 'saveActiveItemAs', 'saveItem', 'saveItemAs', 'saveItems',
'itemForUri', 'showItemForUri', 'promptToSaveItem', 'copyActiveItem', 'isActive',
'activate', toProperty: 'model'
previousActiveItem: null