From a3ad553d1f20f55170a500aadd30d44ec57f2bb2 Mon Sep 17 00:00:00 2001 From: BrainCrumbz Date: Wed, 20 Apr 2016 17:45:15 +0200 Subject: [PATCH 1/3] :memo: [ci skip] add notes on 'apm' path in Windows Comments came out while discussing issue #11137 --- docs/build-instructions/windows.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/docs/build-instructions/windows.md b/docs/build-instructions/windows.md index 09be1b953..c83ae6612 100644 --- a/docs/build-instructions/windows.md +++ b/docs/build-instructions/windows.md @@ -36,6 +36,17 @@ To also install the newly built application, use `script\build --create-windows- * `--create-windows-installer`: creates an `.msi`, an `.exe` and a `.nupkg` installer in the `out/` directory. * `--install`: installs the application in `%LOCALAPPDATA%\Atom\app-dev\`. +### Running tests + +In order to run tests from command line you need `apm`, available after you install Atom or after you build that from scratch. If you installed it, run the following commands (assuming `C:\atom` is the root path of your Atom sources): + +```bash +cd C:\atom +apm test +``` + +When building Atom from scratch instead, the `apm` command is not added to the system path by default. In this case, you can either add it yourselves or you can explicitly list the complete path in previous commands. Anyway, its default location on a Win 64-bit installation is `"C:\Program Files (x86)\Atom\resources\cli\"`. + ## Troubleshooting ### Common Errors From 3277752cb01989825d9c823326fa20921c84d413 Mon Sep 17 00:00:00 2001 From: BrainCrumbz Date: Fri, 22 Apr 2016 09:48:40 +0200 Subject: [PATCH 2/3] :memo: [ci skip] apply suggested changes after PR --- docs/build-instructions/windows.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/build-instructions/windows.md b/docs/build-instructions/windows.md index c83ae6612..53567ddc2 100644 --- a/docs/build-instructions/windows.md +++ b/docs/build-instructions/windows.md @@ -38,14 +38,14 @@ To also install the newly built application, use `script\build --create-windows- ### Running tests -In order to run tests from command line you need `apm`, available after you install Atom or after you build that from scratch. If you installed it, run the following commands (assuming `C:\atom` is the root path of your Atom sources): +In order to run tests from command line you need `apm`, available after you install Atom or after you build from source. If you installed it, run the following commands (assuming `C:\atom` is the root of your Atom repository): ```bash cd C:\atom apm test ``` -When building Atom from scratch instead, the `apm` command is not added to the system path by default. In this case, you can either add it yourselves or you can explicitly list the complete path in previous commands. Anyway, its default location on a Win 64-bit installation is `"C:\Program Files (x86)\Atom\resources\cli\"`. +When building Atom from source, the `apm` command is not added to the system path by default. In this case, you can either add it yourself or explicitly list the complete path in previous commands. Anyway, its default location on a Win 64-bit installation is `"C:\Program Files (x86)\Atom\resources\cli\"`. ## Troubleshooting From 679acc4748b59a3e640e6be7cb1a69ac7c409b87 Mon Sep 17 00:00:00 2001 From: Giuseppe Piscopo Date: Mon, 31 Oct 2016 10:54:28 +0100 Subject: [PATCH 3/3] :memo: [ci skip] add note on windows tests failing --- docs/build-instructions/windows.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/build-instructions/windows.md b/docs/build-instructions/windows.md index 53567ddc2..03f0505ba 100644 --- a/docs/build-instructions/windows.md +++ b/docs/build-instructions/windows.md @@ -47,6 +47,8 @@ apm test When building Atom from source, the `apm` command is not added to the system path by default. In this case, you can either add it yourself or explicitly list the complete path in previous commands. Anyway, its default location on a Win 64-bit installation is `"C:\Program Files (x86)\Atom\resources\cli\"`. +**NOTE**: Please keep in mind that there are still some Windows tests that don't pass. + ## Troubleshooting ### Common Errors