From ae2f4ac36e7178e673774a2cd3e6b4db7d7802f6 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 29 Oct 2014 09:22:06 -0700 Subject: [PATCH 1/8] Remove feedback package --- package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/package.json b/package.json index fb9e309bd..1fa278719 100644 --- a/package.json +++ b/package.json @@ -84,7 +84,6 @@ "dev-live-reload": "0.34.0", "encoding-selector": "0.4.0", "exception-reporting": "0.20.0", - "feedback": "0.33.0", "find-and-replace": "0.141.0", "fuzzy-finder": "0.60.0", "git-diff": "0.42.0", From 61f75b0764ac5e9a3ca8584581fdedf017dce48c Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 29 Oct 2014 09:23:49 -0700 Subject: [PATCH 2/8] Add discussions to Help menu --- menus/darwin.cson | 1 + src/browser/atom-application.coffee | 1 + 2 files changed, 2 insertions(+) diff --git a/menus/darwin.cson b/menus/darwin.cson index 9ad0fa9fa..7cf5bccc8 100644 --- a/menus/darwin.cson +++ b/menus/darwin.cson @@ -190,6 +190,7 @@ submenu: [ { label: 'Terms of Use', command: 'application:open-terms-of-use' } { label: 'Documentation', command: 'application:open-documentation' } + { label: 'Community Discussions', command: 'application:open-discussions' } { type: 'separator' } ] } diff --git a/src/browser/atom-application.coffee b/src/browser/atom-application.coffee index 4eb6dc401..abf90ca31 100644 --- a/src/browser/atom-application.coffee +++ b/src/browser/atom-application.coffee @@ -155,6 +155,7 @@ class AtomApplication atomWindow?.browserWindow.inspectElement(x, y) @on 'application:open-documentation', -> require('shell').openExternal('https://atom.io/docs/latest/?app') + @on 'application:open-discussions', -> require('shell').openExternal('https://discuss.atom.io') @on 'application:open-terms-of-use', -> require('shell').openExternal('https://atom.io/terms') @on 'application:install-update', -> @autoUpdateManager.install() @on 'application:check-for-update', => @autoUpdateManager.check() From 9f80be4570eedfe6cedaf168b2e0177e2ecd25dc Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 29 Oct 2014 09:24:58 -0700 Subject: [PATCH 3/8] Add roadmap to help menu --- menus/darwin.cson | 1 + src/browser/atom-application.coffee | 1 + 2 files changed, 2 insertions(+) diff --git a/menus/darwin.cson b/menus/darwin.cson index 7cf5bccc8..d483108f0 100644 --- a/menus/darwin.cson +++ b/menus/darwin.cson @@ -191,6 +191,7 @@ { label: 'Terms of Use', command: 'application:open-terms-of-use' } { label: 'Documentation', command: 'application:open-documentation' } { label: 'Community Discussions', command: 'application:open-discussions' } + { label: 'Roadmap', command: 'application:open-roadmap' } { type: 'separator' } ] } diff --git a/src/browser/atom-application.coffee b/src/browser/atom-application.coffee index abf90ca31..fb1f0331d 100644 --- a/src/browser/atom-application.coffee +++ b/src/browser/atom-application.coffee @@ -156,6 +156,7 @@ class AtomApplication @on 'application:open-documentation', -> require('shell').openExternal('https://atom.io/docs/latest/?app') @on 'application:open-discussions', -> require('shell').openExternal('https://discuss.atom.io') + @on 'application:open-roadmap', -> require('shell').openExternal('https://atom.io/roadmap?app') @on 'application:open-terms-of-use', -> require('shell').openExternal('https://atom.io/terms') @on 'application:install-update', -> @autoUpdateManager.install() @on 'application:check-for-update', => @autoUpdateManager.check() From cefabd4eb8392951bacc92ba6f5ddbb9ef3748ec Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 29 Oct 2014 09:26:06 -0700 Subject: [PATCH 4/8] Add FAQ to help menu --- menus/darwin.cson | 1 + src/browser/atom-application.coffee | 1 + 2 files changed, 2 insertions(+) diff --git a/menus/darwin.cson b/menus/darwin.cson index d483108f0..afaeccc45 100644 --- a/menus/darwin.cson +++ b/menus/darwin.cson @@ -192,6 +192,7 @@ { label: 'Documentation', command: 'application:open-documentation' } { label: 'Community Discussions', command: 'application:open-discussions' } { label: 'Roadmap', command: 'application:open-roadmap' } + { label: 'Frequently Asked Questions', command: 'application:open-faq' } { type: 'separator' } ] } diff --git a/src/browser/atom-application.coffee b/src/browser/atom-application.coffee index fb1f0331d..715b435b3 100644 --- a/src/browser/atom-application.coffee +++ b/src/browser/atom-application.coffee @@ -157,6 +157,7 @@ class AtomApplication @on 'application:open-documentation', -> require('shell').openExternal('https://atom.io/docs/latest/?app') @on 'application:open-discussions', -> require('shell').openExternal('https://discuss.atom.io') @on 'application:open-roadmap', -> require('shell').openExternal('https://atom.io/roadmap?app') + @on 'application:open-faq', -> require('shell').openExternal('https://atom.io/faq') @on 'application:open-terms-of-use', -> require('shell').openExternal('https://atom.io/terms') @on 'application:install-update', -> @autoUpdateManager.install() @on 'application:check-for-update', => @autoUpdateManager.check() From 05c1ae71e1628337d66691c06e86718e13d04a82 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 29 Oct 2014 09:28:49 -0700 Subject: [PATCH 5/8] Add report issue to Help menu --- menus/darwin.cson | 1 + src/browser/atom-application.coffee | 2 ++ 2 files changed, 3 insertions(+) diff --git a/menus/darwin.cson b/menus/darwin.cson index afaeccc45..4c2817e09 100644 --- a/menus/darwin.cson +++ b/menus/darwin.cson @@ -193,6 +193,7 @@ { label: 'Community Discussions', command: 'application:open-discussions' } { label: 'Roadmap', command: 'application:open-roadmap' } { label: 'Frequently Asked Questions', command: 'application:open-faq' } + { label: 'Report Issue', command: 'application:report-issue' } { type: 'separator' } ] } diff --git a/src/browser/atom-application.coffee b/src/browser/atom-application.coffee index 715b435b3..2516ec8d0 100644 --- a/src/browser/atom-application.coffee +++ b/src/browser/atom-application.coffee @@ -159,6 +159,8 @@ class AtomApplication @on 'application:open-roadmap', -> require('shell').openExternal('https://atom.io/roadmap?app') @on 'application:open-faq', -> require('shell').openExternal('https://atom.io/faq') @on 'application:open-terms-of-use', -> require('shell').openExternal('https://atom.io/terms') + @on 'application:report-issue', -> require('shell').openExternal('https://github.com/atom/atom/issues/new') + @on 'application:install-update', -> @autoUpdateManager.install() @on 'application:check-for-update', => @autoUpdateManager.check() From 7641f1d1e40d7518013edd6544e1d83e141e24fb Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 29 Oct 2014 09:31:53 -0700 Subject: [PATCH 6/8] Sync help menus on Linux/Windows --- menus/linux.cson | 4 ++++ menus/win32.cson | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/menus/linux.cson b/menus/linux.cson index 7560f1ae8..bbf46e7ca 100644 --- a/menus/linux.cson +++ b/menus/linux.cson @@ -147,6 +147,10 @@ { label: "VERSION", enabled: false } { type: 'separator' } { label: '&Documentation', command: 'application:open-documentation' } + { label: 'Community Discussions', command: 'application:open-discussions' } + { label: 'Roadmap', command: 'application:open-roadmap' } + { label: 'Frequently Asked Questions', command: 'application:open-faq' } + { label: 'Report Issue', command: 'application:report-issue' } { type: 'separator' } ] } diff --git a/menus/win32.cson b/menus/win32.cson index 78c8f2f00..7303aada8 100644 --- a/menus/win32.cson +++ b/menus/win32.cson @@ -165,6 +165,10 @@ { label: "VERSION", enabled: false } { type: 'separator' } { label: '&Documentation', command: 'application:open-documentation' } + { label: 'Community Discussions', command: 'application:open-discussions' } + { label: 'Roadmap', command: 'application:open-roadmap' } + { label: 'Frequently Asked Questions', command: 'application:open-faq' } + { label: 'Report Issue', command: 'application:report-issue' } { type: 'separator' } ] } From 037a7f435cdc842ee3daf84012c0760376114f0c Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Thu, 30 Oct 2014 09:06:54 -0700 Subject: [PATCH 7/8] Add search issues to help menu --- menus/darwin.cson | 1 + menus/linux.cson | 1 + menus/win32.cson | 1 + src/browser/atom-application.coffee | 1 + 4 files changed, 4 insertions(+) diff --git a/menus/darwin.cson b/menus/darwin.cson index 4c2817e09..34c662ccb 100644 --- a/menus/darwin.cson +++ b/menus/darwin.cson @@ -194,6 +194,7 @@ { label: 'Roadmap', command: 'application:open-roadmap' } { label: 'Frequently Asked Questions', command: 'application:open-faq' } { label: 'Report Issue', command: 'application:report-issue' } + { label: 'Search Issues', command: 'application:search-issues' } { type: 'separator' } ] } diff --git a/menus/linux.cson b/menus/linux.cson index bbf46e7ca..6b2852929 100644 --- a/menus/linux.cson +++ b/menus/linux.cson @@ -151,6 +151,7 @@ { label: 'Roadmap', command: 'application:open-roadmap' } { label: 'Frequently Asked Questions', command: 'application:open-faq' } { label: 'Report Issue', command: 'application:report-issue' } + { label: 'Search Issues', command: 'application:search-issues' } { type: 'separator' } ] } diff --git a/menus/win32.cson b/menus/win32.cson index 7303aada8..dbe7e6b51 100644 --- a/menus/win32.cson +++ b/menus/win32.cson @@ -169,6 +169,7 @@ { label: 'Roadmap', command: 'application:open-roadmap' } { label: 'Frequently Asked Questions', command: 'application:open-faq' } { label: 'Report Issue', command: 'application:report-issue' } + { label: 'Search Issues', command: 'application:search-issues' } { type: 'separator' } ] } diff --git a/src/browser/atom-application.coffee b/src/browser/atom-application.coffee index 2516ec8d0..8e1f66ec0 100644 --- a/src/browser/atom-application.coffee +++ b/src/browser/atom-application.coffee @@ -160,6 +160,7 @@ class AtomApplication @on 'application:open-faq', -> require('shell').openExternal('https://atom.io/faq') @on 'application:open-terms-of-use', -> require('shell').openExternal('https://atom.io/terms') @on 'application:report-issue', -> require('shell').openExternal('https://github.com/atom/atom/issues/new') + @on 'application:search-issues', -> require('shell').openExternal('https://github.com/issues?q=+is%3Aissue+user%3Aatom') @on 'application:install-update', -> @autoUpdateManager.install() @on 'application:check-for-update', => @autoUpdateManager.check() From a153f1e24451f5f6e7e469c1e0b8270e75530c82 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Thu, 30 Oct 2014 09:09:44 -0700 Subject: [PATCH 8/8] Move items around in help menu a bit --- menus/darwin.cson | 3 ++- menus/linux.cson | 3 ++- menus/win32.cson | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/menus/darwin.cson b/menus/darwin.cson index 34c662ccb..ace113a2f 100644 --- a/menus/darwin.cson +++ b/menus/darwin.cson @@ -190,9 +190,10 @@ submenu: [ { label: 'Terms of Use', command: 'application:open-terms-of-use' } { label: 'Documentation', command: 'application:open-documentation' } - { label: 'Community Discussions', command: 'application:open-discussions' } { label: 'Roadmap', command: 'application:open-roadmap' } { label: 'Frequently Asked Questions', command: 'application:open-faq' } + { type: 'separator' } + { label: 'Community Discussions', command: 'application:open-discussions' } { label: 'Report Issue', command: 'application:report-issue' } { label: 'Search Issues', command: 'application:search-issues' } { type: 'separator' } diff --git a/menus/linux.cson b/menus/linux.cson index 6b2852929..911dbd33e 100644 --- a/menus/linux.cson +++ b/menus/linux.cson @@ -147,9 +147,10 @@ { label: "VERSION", enabled: false } { type: 'separator' } { label: '&Documentation', command: 'application:open-documentation' } - { label: 'Community Discussions', command: 'application:open-discussions' } { label: 'Roadmap', command: 'application:open-roadmap' } { label: 'Frequently Asked Questions', command: 'application:open-faq' } + { type: 'separator' } + { label: 'Community Discussions', command: 'application:open-discussions' } { label: 'Report Issue', command: 'application:report-issue' } { label: 'Search Issues', command: 'application:search-issues' } { type: 'separator' } diff --git a/menus/win32.cson b/menus/win32.cson index dbe7e6b51..1220e3a93 100644 --- a/menus/win32.cson +++ b/menus/win32.cson @@ -165,9 +165,10 @@ { label: "VERSION", enabled: false } { type: 'separator' } { label: '&Documentation', command: 'application:open-documentation' } - { label: 'Community Discussions', command: 'application:open-discussions' } { label: 'Roadmap', command: 'application:open-roadmap' } { label: 'Frequently Asked Questions', command: 'application:open-faq' } + { type: 'separator' } + { label: 'Community Discussions', command: 'application:open-discussions' } { label: 'Report Issue', command: 'application:report-issue' } { label: 'Search Issues', command: 'application:search-issues' } { type: 'separator' }