From 65bcd888f392aa099996d5b5dabf8ff2f9941e9e Mon Sep 17 00:00:00 2001 From: Ash Wilson Date: Fri, 27 Jul 2018 10:18:42 -0400 Subject: [PATCH] Update LineNumberComponent correctly when "number" changes --- src/text-editor-component.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/text-editor-component.js b/src/text-editor-component.js index d9f784d70..0d428089b 100644 --- a/src/text-editor-component.js +++ b/src/text-editor-component.js @@ -3427,14 +3427,17 @@ class LineNumberComponent { this.element.style.marginTop = '' } } + if (this.props.number !== number) { - if (number) { - this.element.insertBefore(nodePool.getTextNode(number), this.element.firstChild) - } else { + if (this.props.number != null) { const numberNode = this.element.firstChild numberNode.remove() nodePool.release(numberNode) } + + if (number != null) { + this.element.insertBefore(nodePool.getTextNode(number), this.element.firstChild); + } } this.props = props