github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-06 03:02:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use padding-top/bottom rather than spacer divs in lines and gutter

Browse Source 
It creates a simpler DOM structure.
This commit is contained in:
Nathan Sobo
2014-04-16 13:56:24 -06:00
parent 3a42346e5e
commit 6607f99c6c
3 changed files with 24 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/lines-component.coffee
View File

@@ -14,15 +14,12 @@ LinesComponent = React.createClass
{editor, visibleRowRange, showIndentGuide} = @props
[startRow, endRow] = visibleRowRange
lineHeightInPixels = editor.getLineHeight()
precedingHeight = startRow * lineHeightInPixels
followingHeight = (editor.getScreenLineCount() - endRow) * lineHeightInPixels
paddingTop = startRow * lineHeightInPixels
paddingBottom = (editor.getScreenLineCount() - endRow) * lineHeightInPixels
div className: 'lines', ref: 'lines', [
div className: 'spacer', key: 'top-spacer', style: {height: precedingHeight}
(for tokenizedLine in @props.editor.linesForScreenRows(startRow, endRow - 1)
LineComponent({tokenizedLine, showIndentGuide, key: tokenizedLine.id}))...
div className: 'spacer', key: 'bottom-spacer', style: {height: followingHeight}
]
div className: 'lines', ref: 'lines', style: {paddingTop, paddingBottom},
for tokenizedLine in @props.editor.linesForScreenRows(startRow, endRow - 1)
LineComponent({tokenizedLine, showIndentGuide, key: tokenizedLine.id})
componentDidMount: ->
@measuredLines = new WeakSet
@@ -62,7 +59,7 @@ LinesComponent = React.createClass
for tokenizedLine, i in @props.editor.linesForScreenRows(visibleStartRow, visibleEndRow - 1)
unless @measuredLines.has(tokenizedLine)
lineNode = linesNode.children[i + 1]
lineNode = linesNode.children[i]
@measureCharactersInLine(tokenizedLine, lineNode)
measureCharactersInLine: (tokenizedLine, lineNode) ->