From 66707fc42381e9b3be36d0c9fa48a8a973e9d4b0 Mon Sep 17 00:00:00 2001 From: Corey Johnson & Nathan Sobo Date: Tue, 10 Jan 2012 17:44:09 -0800 Subject: [PATCH] Return false if no key binding matches. Don't loop forever. --- src/atom/global-keymap.coffee | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/atom/global-keymap.coffee b/src/atom/global-keymap.coffee index c5703e466..e472c3237 100644 --- a/src/atom/global-keymap.coffee +++ b/src/atom/global-keymap.coffee @@ -14,7 +14,7 @@ class GlobalKeymap handleKeyEvent: (event) -> currentNode = $(event.target) - while currentNode isnt document + while currentNode.length candidateBindingSets = @bindingSets.filter (set) -> currentNode.is(set.selector) candidateBindingSets.sort (a, b) -> b.specificity - a.specificity for bindingSet in candidateBindingSets @@ -22,4 +22,4 @@ class GlobalKeymap $(event.target).trigger(command) return currentNode = currentNode.parent() - + false