From 670b44f2505d0b5795c2e1b8c5139dab2acc94ee Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Wed, 5 Nov 2014 11:20:55 -0700 Subject: [PATCH] Only set both height and width of editor when shadow DOM is used These work inside a shadow root, but break the flexbox behavior when the shadow DOM is disabled. --- src/text-editor-element.coffee | 1 + static/text-editor-shadow.less | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/text-editor-element.coffee b/src/text-editor-element.coffee index a5430cb5a..4a428178e 100644 --- a/src/text-editor-element.coffee +++ b/src/text-editor-element.coffee @@ -34,6 +34,7 @@ class TextEditorElement extends HTMLElement @stylesElement.initialize() @rootElement = document.createElement('div') + @rootElement.classList.add('shadow') @shadowRoot.appendChild(@stylesElement) @shadowRoot.appendChild(@rootElement) diff --git a/static/text-editor-shadow.less b/static/text-editor-shadow.less index 8187bdf93..c6d2ab57c 100644 --- a/static/text-editor-shadow.less +++ b/static/text-editor-shadow.less @@ -2,7 +2,11 @@ @import "octicon-utf-codes"; @import "octicon-mixins"; -.editor, .editor-contents { +.editor-contents { + width: 100%; +} + +.editor.shadow, .editor.shadow .editor-contents { height: 100%; width: 100%; }