github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-11 07:05:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Replace layerUpdateDisposablesByLayerId with a weak map keyed by layer

Browse Source
This commit is contained in:
Nathan Sobo
2017-03-03 05:58:03 -07:00
committed by Antonio Scandurra
parent a1faf66a85
commit 69d5b63e9d
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/decoration-manager.js
View File

@@ -13,7 +13,7 @@ class DecorationManager {
this.overlayDecorations = new Set()
this.layerDecorationsByMarkerLayer = new Map()
this.decorationCountsByLayer = new Map()
this.layerUpdateDisposablesByLayerId = {}
this.layerUpdateDisposablesByLayer = new WeakMap()
}
observeDecorations (callback) {
@@ -234,16 +234,15 @@ class DecorationManager {
const newCount = (this.decorationCountsByLayer.get(layer) || 0) + 1
this.decorationCountsByLayer.set(layer, newCount)
if (newCount === 1) {
this.layerUpdateDisposablesByLayerId[layer.id] = layer.onDidUpdate(this.emitDidUpdateDecorations.bind(this))
this.layerUpdateDisposablesByLayer.set(layer, layer.onDidUpdate(this.emitDidUpdateDecorations.bind(this)))
}
}
unobserveDecoratedLayer (layer) {
const newCount = this.decorationCountsByLayer.get(layer) - 1
if (newCount === 0) {
this.layerUpdateDisposablesByLayerId[layer.id].dispose()
this.layerUpdateDisposablesByLayer.get(layer).dispose()
this.decorationCountsByLayer.delete(layer)
delete this.layerUpdateDisposablesByLayerId[layer.id]
} else {
this.decorationCountsByLayer.set(layer, newCount)
}