From 0dd08dd3d20c3121897b9a59a070329495bb380d Mon Sep 17 00:00:00 2001 From: probablycorey Date: Wed, 25 Sep 2013 17:19:30 -0700 Subject: [PATCH 1/6] Add tiny dev tools status indicator --- src/root-view.coffee | 2 ++ static/root-view.less | 13 +++++++++++++ 2 files changed, 15 insertions(+) diff --git a/src/root-view.coffee b/src/root-view.coffee index a4b2a202f..1f2ecd13a 100644 --- a/src/root-view.coffee +++ b/src/root-view.coffee @@ -65,6 +65,8 @@ class RootView extends View # Private: initialize: (state={}) -> + @prepend("
") if atom.getLoadSettings().devMode + if state instanceof telepath.Document @state = state panes = deserialize(state.get('panes')) diff --git a/static/root-view.less b/static/root-view.less index 5e8fbe2ed..914086e7d 100644 --- a/static/root-view.less +++ b/static/root-view.less @@ -37,6 +37,19 @@ h6 { -webkit-flex: 1; -webkit-flex-flow: column; } + + .dev-mode { + position: absolute; + top: 0; + right: 0; + width: 10px; + height: 10px; + z-index: 1000; + opacity: 0.75; + border: 5px #CF4647 solid; + border-bottom-color: transparent; + border-left-color: transparent; + } } #panes { From 92edaf157ab1e7ca84314b8068d5509036bc5258 Mon Sep 17 00:00:00 2001 From: probablycorey Date: Wed, 25 Sep 2013 17:22:56 -0700 Subject: [PATCH 2/6] Use warning color --- static/root-view.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/root-view.less b/static/root-view.less index 914086e7d..47012176c 100644 --- a/static/root-view.less +++ b/static/root-view.less @@ -46,7 +46,7 @@ h6 { height: 10px; z-index: 1000; opacity: 0.75; - border: 5px #CF4647 solid; + border: 5px @background-color-warning solid; border-bottom-color: transparent; border-left-color: transparent; } From cceb2ebac2780326a70bed9b951eaffd768b18f1 Mon Sep 17 00:00:00 2001 From: probablycorey Date: Wed, 25 Sep 2013 17:23:16 -0700 Subject: [PATCH 3/6] Remove skull from application menu BECAUSE IT IS A LIE --- src/application-menu.coffee | 4 +--- src/atom-application.coffee | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/application-menu.coffee b/src/application-menu.coffee index 404229498..be808acc8 100644 --- a/src/application-menu.coffee +++ b/src/application-menu.coffee @@ -9,10 +9,9 @@ _ = require 'underscore' module.exports = class ApplicationMenu version: null - devMode: null menu: null - constructor: (@version, @devMode) -> + constructor: (@version) -> @menu = Menu.buildFromTemplate @getDefaultTemplate() Menu.setApplicationMenu @menu @@ -149,7 +148,6 @@ class ApplicationMenu submenu: [ { label: 'In Development Mode', enabled: false } ] template = [atomMenu, fileMenu, editMenu, viewMenu, windowMenu] - template.push devMenu if @devMode @translateTemplate template, keystrokesByCommand diff --git a/src/atom-application.coffee b/src/atom-application.coffee index 690c21332..dd09dcef6 100644 --- a/src/atom-application.coffee +++ b/src/atom-application.coffee @@ -57,7 +57,7 @@ class AtomApplication @pathsToOpen ?= [] @windows = [] - @applicationMenu = new ApplicationMenu(@version, devMode) + @applicationMenu = new ApplicationMenu(@version) @atomProtocolHandler = new AtomProtocolHandler(@resourcePath) @listenForArgumentsFromNewProcess() From 687776c3fbc836a84ccf169496f40671db603390 Mon Sep 17 00:00:00 2001 From: probablycorey Date: Thu, 26 Sep 2013 14:26:07 -0700 Subject: [PATCH 4/6] Use spacepen for html generation For consistency --- src/root-view.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/root-view.coffee b/src/root-view.coffee index 4fdb4816f..6f3bf8734 100644 --- a/src/root-view.coffee +++ b/src/root-view.coffee @@ -65,7 +65,7 @@ class RootView extends View # Private: initialize: (state={}) -> - @prepend("
") if atom.getLoadSettings().devMode + @prepend($$ -> @div class: 'dev-mode') if atom.getLoadSettings().devMode if state instanceof telepath.Document @state = state From 35c8d53275a42c0e998626ef1dda55e5b37149fc Mon Sep 17 00:00:00 2001 From: probablycorey Date: Thu, 26 Sep 2013 14:26:28 -0700 Subject: [PATCH 5/6] Use a skull and crossbones instead of a triangle --- static/root-view.less | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/static/root-view.less b/static/root-view.less index 47012176c..973ed3577 100644 --- a/static/root-view.less +++ b/static/root-view.less @@ -39,16 +39,19 @@ h6 { } .dev-mode { + + &:before { + content: ""; // This is not a space, it is a skull and crossbones + } + position: absolute; top: 0; right: 0; - width: 10px; - height: 10px; + font-family: Wingdings; + font-size: 25px; z-index: 1000; opacity: 0.75; - border: 5px @background-color-warning solid; - border-bottom-color: transparent; - border-left-color: transparent; + color: @text-color-highlight; } } From 33a7ff87228707d4b23a35560c72820bb59c12b2 Mon Sep 17 00:00:00 2001 From: probablycorey Date: Thu, 26 Sep 2013 14:32:44 -0700 Subject: [PATCH 6/6] Add padding to skull --- static/root-view.less | 1 + 1 file changed, 1 insertion(+) diff --git a/static/root-view.less b/static/root-view.less index 973ed3577..3f56af5eb 100644 --- a/static/root-view.less +++ b/static/root-view.less @@ -44,6 +44,7 @@ h6 { content: ""; // This is not a space, it is a skull and crossbones } + padding: @component-icon-padding; position: absolute; top: 0; right: 0;