From 6eed4e461f97db4d581c0c87dfbf7f1dc755012a Mon Sep 17 00:00:00 2001 From: Lee Dohm Date: Sun, 1 Feb 2015 08:35:57 -0800 Subject: [PATCH] :memo: Give stronger recommendation on deactivate Many packages don't clean up properly on update, causing strange behavior until restart. Simply stating that the `deactivate` method is optional is enough to let people know that it isn't required for the common case. --- docs/creating-a-package.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/creating-a-package.md b/docs/creating-a-package.md index cfedd62b2..2343c0010 100644 --- a/docs/creating-a-package.md +++ b/docs/creating-a-package.md @@ -98,9 +98,9 @@ module's `activate` method so you can restore your view to where the user left off. - `deactivate()`: This **optional** method is called when the window is shutting -down. If your package is watching any files or holding external resources in any -other way, release them here. If you're just subscribing to things on window, -you don't need to worry because that's getting torn down anyway. +down, or when your package is being updated or disabled. If your package is +watching any files, holding external resources, providing commands or subscribing +to events release them here. ### Simple Package Code