From 713615d515cb2096c987d2f75862a3a46ec5e6df Mon Sep 17 00:00:00 2001
From: Corey Johnson & Nathan Sobo <cj+nathan@github.com>
Date: Mon, 23 Jan 2012 14:18:34 -0800
Subject: [PATCH] Retain goal column when moving cursor up.

---
 spec/atom/editor-spec.coffee | 76 +++++++++++++++++++++++-------------
 src/atom/cursor.coffee       |  3 ++
 2 files changed, 51 insertions(+), 28 deletions(-)

diff --git a/spec/atom/editor-spec.coffee b/spec/atom/editor-spec.coffee
index d6c975f6c..d924f62a6 100644
--- a/spec/atom/editor-spec.coffee
+++ b/spec/atom/editor-spec.coffee
@@ -48,35 +48,55 @@ fdescribe "Editor", ->
         editor.moveUp()
         expect(editor.getPosition()).toEqual(row: 0, col: 0)
 
+
+    describe "goal column retention", ->
+      lineLengths = null
+
+      beforeEach ->
+        lineLengths = buffer.getLines().map (line) -> line.length
+        expect(lineLengths[3]).toBeGreaterThan(lineLengths[4])
+        expect(lineLengths[5]).toBeGreaterThan(lineLengths[4])
+        expect(lineLengths[6]).toBeGreaterThan(lineLengths[3])
+
+      it "retains the goal column when moving up", ->
+        expect(lineLengths[6]).toBeGreaterThan(32)
+        editor.setPosition(row: 6, col: 32)
+
+        editor.moveUp()
+        expect(editor.getPosition().col).toBe lineLengths[5]
+
+        editor.moveUp()
+        expect(editor.getPosition().col).toBe lineLengths[4]
+
+        editor.moveUp()
+        expect(editor.getPosition().col).toBe 32
+
+      it "retains the goal column when moving down", ->
+        editor.setPosition(row: 3, col: lineLengths[3])
+
+        editor.moveDown()
+        expect(editor.getPosition().col).toBe lineLengths[4]
+
+        editor.moveDown()
+        expect(editor.getPosition().col).toBe lineLengths[5]
+
+        editor.moveDown()
+        expect(editor.getPosition().col).toBe lineLengths[3]
+
+      it "clears the goal column when the cursor is set", ->
+        # set a goal column by moving down
+        editor.setPosition(row: 3, col: lineLengths[3])
+        editor.moveDown()
+        expect(editor.getPosition().col).not.toBe 6
+
+        # clear the goal column by explicitly setting the cursor position
+        editor.setColumn(6)
+        expect(editor.getPosition().col).toBe 6
+
+        editor.moveDown()
+        expect(editor.getPosition().col).toBe 6
+
     describe "down", ->
-      describe "when moving between lines of varying length", ->
-        it "retains a goal column, keeping the cursor as close to the original x position as possible", ->
-          lineLengths = buffer.getLines().map (line) -> line.length
-          expect(lineLengths[3]).toBeGreaterThan(lineLengths[4])
-          expect(lineLengths[5]).toBeGreaterThan(lineLengths[4])
-          expect(lineLengths[6]).toBeGreaterThan(lineLengths[3])
-
-          editor.setPosition(row: 3, col: lineLengths[3])
-
-          editor.moveDown()
-          expect(editor.getPosition().col).toBe lineLengths[4]
-
-          editor.moveDown()
-          expect(editor.getPosition().col).toBe lineLengths[5]
-
-          editor.moveDown()
-          expect(editor.getPosition().col).toBe lineLengths[3]
-
-          # ensure goal column gets reset when there's non-vertical movement
-          editor.setColumn(6)
-          expect(editor.getPosition().col).toBe 6
-
-          editor.moveDown()
-          expect(editor.getPosition().col).toBe lineLengths[7]
-
-          editor.moveDown()
-          expect(editor.getPosition().col).toBe 6
-
       describe "when on the last line", ->
         it "moves the cursor to the end of line", ->
           lastLineIndex = buffer.getLines().length - 1
diff --git a/src/atom/cursor.coffee b/src/atom/cursor.coffee
index ebedcda44..258604930 100644
--- a/src/atom/cursor.coffee
+++ b/src/atom/cursor.coffee
@@ -23,7 +23,10 @@ class Cursor extends Template
         col = 0
       else
         row--
+
+      col = @goalColumn if @goalColumn
       @setPosition({row, col})
+      @goalColumn ?= col
 
     moveDown: ->
       { row, col } = @getPosition()