github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Maintain a map of line components instead of line nodes and text nodes

Browse Source 
Other than simplifying the code, this will help us understand whether
https://github.com/atom/atom/issues/15263 might be related to a node
reuse issue.

Signed-off-by: Nathan Sobo <nathan@github.com>
This commit is contained in:
Antonio Scandurra
2017-08-23 14:52:50 +02:00
committed by Nathan Sobo
parent eaf358bd3e
commit 74ae169fcc
2 changed files with 37 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/text-editor-component-spec.js
View File

@@ -4225,12 +4225,12 @@ function lineNumberNodeForScreenRow (component, row) {
function lineNodeForScreenRow (component, row) {
const renderedScreenLine = component.renderedScreenLineForRow(row)
return component.lineNodesByScreenLineId.get(renderedScreenLine.id)
return component.lineComponentsByScreenLineId.get(renderedScreenLine.id).element
}
function textNodesForScreenRow (component, row) {
const screenLine = component.renderedScreenLineForRow(row)
return component.textNodesByScreenLineId.get(screenLine.id)
return component.lineComponentsByScreenLineId.get(screenLine.id).textNodes
}
function setScrollTop (component, scrollTop) {