From 772787121c9cc552c3afc2e377eb619f5e5a76af Mon Sep 17 00:00:00 2001 From: Corey Johnson & Nathan Sobo Date: Tue, 26 Mar 2013 11:25:09 -0600 Subject: [PATCH] Remove atom package grammars on deactivate --- spec/app/atom-spec.coffee | 6 ++++++ src/app/atom-package.coffee | 1 + 2 files changed, 7 insertions(+) diff --git a/spec/app/atom-spec.coffee b/spec/app/atom-spec.coffee index 991916d1d..c479f58b3 100644 --- a/spec/app/atom-spec.coffee +++ b/spec/app/atom-spec.coffee @@ -144,6 +144,12 @@ describe "the `atom` global", -> expect(atom.packageStates['package-with-serialization']).toEqual someNumber: 1 expect(console.error).toHaveBeenCalled() + it "removes the package's grammars", -> + atom.activatePackage('package-with-grammars') + atom.deactivatePackage('package-with-grammars') + expect(syntax.selectGrammar('a.alot').name).toBe 'Null Grammar' + expect(syntax.selectGrammar('a.alittle').name).toBe 'Null Grammar' + describe "texmate packages", -> it "removes the package's grammars", -> expect(syntax.selectGrammar("file.rb").name).toBe "Null Grammar" diff --git a/src/app/atom-package.coffee b/src/app/atom-package.coffee index 75e9f52a6..dc27d70ac 100644 --- a/src/app/atom-package.coffee +++ b/src/app/atom-package.coffee @@ -97,6 +97,7 @@ class AtomPackage extends Package console.error "Error serializing package '#{@name}'", e.stack deactivate: -> + syntax.removeGrammar(grammar) for grammar in @grammars @mainModule?.deactivate?() requireMainModule: ->