From 80bd25cf80e89643680919af8db1ccb94ff04fb6 Mon Sep 17 00:00:00 2001 From: Wliu <50Wliu@users.noreply.github.com> Date: Wed, 4 Nov 2015 13:59:02 -0500 Subject: [PATCH 1/7] :arrow_up: language-ruby-on-rails@0.24.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 38b2dc3e1..8c415d20e 100644 --- a/package.json +++ b/package.json @@ -138,7 +138,7 @@ "language-property-list": "0.8.0", "language-python": "0.41.0", "language-ruby": "0.60.0", - "language-ruby-on-rails": "0.23.0", + "language-ruby-on-rails": "0.24.0", "language-sass": "0.42.1", "language-shellscript": "0.19.0", "language-source": "0.9.0", From 5f8b2b643bf66ea1acf9b8ebfb0b5db08af93366 Mon Sep 17 00:00:00 2001 From: Wliu Date: Wed, 4 Nov 2015 16:00:57 -0500 Subject: [PATCH 2/7] Include package name metadata when creating errors --- src/package-manager.coffee | 2 +- src/package.coffee | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/package-manager.coffee b/src/package-manager.coffee index f6cef9465..5c0df4b70 100644 --- a/src/package-manager.coffee +++ b/src/package-manager.coffee @@ -467,7 +467,7 @@ class PackageManager detail = "#{error.message} in #{metadataPath}" stack = "#{error.stack}\n at #{metadataPath}:1:1" message = "Failed to load the #{path.basename(packagePath)} package" - @notificationManager.addError(message, {stack, detail, dismissable: true}) + @notificationManager.addError(message, {stack, detail, packageName: path.basename(packagePath), dismissable: true}) uninstallDirectory: (directory) -> symlinkPromise = new Promise (resolve) -> diff --git a/src/package.coffee b/src/package.coffee index 00963ef28..1dac309ab 100644 --- a/src/package.coffee +++ b/src/package.coffee @@ -293,7 +293,7 @@ class Package if error? detail = "#{error.message} in #{grammarPath}" stack = "#{error.stack}\n at #{grammarPath}:1:1" - @notificationManager.addFatalError("Failed to load a #{@name} package grammar", {stack, detail, dismissable: true}) + @notificationManager.addFatalError("Failed to load a #{@name} package grammar", {stack, detail, packageName: @name, dismissable: true}) else grammar.packageName = @name grammar.bundledPackage = @bundledPackage @@ -634,4 +634,4 @@ class Package detail = error.message stack = error.stack ? error - @notificationManager.addFatalError(message, {stack, detail, dismissable: true}) + @notificationManager.addFatalError(message, {stack, detail, packageName: @name, dismissable: true}) From 1bb944dadcf22570690dc53164a31a018cf50a98 Mon Sep 17 00:00:00 2001 From: Wliu Date: Wed, 4 Nov 2015 16:22:01 -0500 Subject: [PATCH 3/7] Add specs --- spec/package-manager-spec.coffee | 7 +++++++ src/package.coffee | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/spec/package-manager-spec.coffee b/spec/package-manager-spec.coffee index 9a2edee0a..88e730d44 100644 --- a/spec/package-manager-spec.coffee +++ b/spec/package-manager-spec.coffee @@ -38,6 +38,7 @@ describe "PackageManager", -> expect(-> pack.reloadStylesheets()).not.toThrow() expect(addErrorHandler.callCount).toBe 2 expect(addErrorHandler.argsForCall[1][0].message).toContain("Failed to reload the package-with-invalid-styles package stylesheets") + expect(addErrorHandler.argsForCall[1][0].options.packageName).toEqual "package-with-invalid-styles" it "returns null if the package has an invalid package.json", -> addErrorHandler = jasmine.createSpy() @@ -45,6 +46,7 @@ describe "PackageManager", -> expect(atom.packages.loadPackage("package-with-broken-package-json")).toBeNull() expect(addErrorHandler.callCount).toBe 1 expect(addErrorHandler.argsForCall[0][0].message).toContain("Failed to load the package-with-broken-package-json package") + expect(addErrorHandler.argsForCall[0][0].options.packageName).toEqual "package-with-broken-package-json" it "normalizes short repository urls in package.json", -> {metadata} = atom.packages.loadPackage("package-with-short-url-package-json") @@ -230,6 +232,7 @@ describe "PackageManager", -> expect(-> atom.packages.activatePackage('package-with-invalid-activation-commands')).not.toThrow() expect(addErrorHandler.callCount).toBe 1 expect(addErrorHandler.argsForCall[0][0].message).toContain("Failed to activate the package-with-invalid-activation-commands package") + expect(addErrorHandler.argsForCall[0][0].options.packageName).toEqual "package-with-invalid-activation-commands" it "adds a notification when the context menu is invalid", -> addErrorHandler = jasmine.createSpy() @@ -237,6 +240,7 @@ describe "PackageManager", -> expect(-> atom.packages.activatePackage('package-with-invalid-context-menu')).not.toThrow() expect(addErrorHandler.callCount).toBe 1 expect(addErrorHandler.argsForCall[0][0].message).toContain("Failed to activate the package-with-invalid-context-menu package") + expect(addErrorHandler.argsForCall[0][0].options.packageName).toEqual "package-with-invalid-context-menu" it "adds a notification when the grammar is invalid", -> addErrorHandler = jasmine.createSpy() @@ -250,6 +254,7 @@ describe "PackageManager", -> runs -> expect(addErrorHandler.callCount).toBe 1 expect(addErrorHandler.argsForCall[0][0].message).toContain("Failed to load a package-with-invalid-grammar package grammar") + expect(addErrorHandler.argsForCall[0][0].options.packageName).toEqual "package-with-invalid-grammar" it "adds a notification when the settings are invalid", -> addErrorHandler = jasmine.createSpy() @@ -263,6 +268,7 @@ describe "PackageManager", -> runs -> expect(addErrorHandler.callCount).toBe 1 expect(addErrorHandler.argsForCall[0][0].message).toContain("Failed to load the package-with-invalid-settings package settings") + expect(addErrorHandler.argsForCall[0][0].options.packageName).toEqual "package-with-invalid-settings" describe "when the package metadata includes `activationHooks`", -> [mainModule, promise] = [] @@ -351,6 +357,7 @@ describe "PackageManager", -> expect(-> atom.packages.activatePackage("package-that-throws-an-exception")).not.toThrow() expect(addErrorHandler.callCount).toBe 1 expect(addErrorHandler.argsForCall[0][0].message).toContain("Failed to load the package-that-throws-an-exception package") + expect(addErrorHandler.argsForCall[0][0].options.packageName).toEqual "package-that-throws-an-exception" describe "when the package is not found", -> it "rejects the promise", -> diff --git a/src/package.coffee b/src/package.coffee index 1dac309ab..4cd6a18fd 100644 --- a/src/package.coffee +++ b/src/package.coffee @@ -317,7 +317,7 @@ class Package if error? detail = "#{error.message} in #{settingsPath}" stack = "#{error.stack}\n at #{settingsPath}:1:1" - @notificationManager.addFatalError("Failed to load the #{@name} package settings", {stack, detail, dismissable: true}) + @notificationManager.addFatalError("Failed to load the #{@name} package settings", {stack, detail, packageName: @name, dismissable: true}) else @settings.push(settings) settings.activate() if @settingsActivated From 5ed9610afcbe7ca3e29c05fd5095bda7e89541a8 Mon Sep 17 00:00:00 2001 From: Wliu <50Wliu@users.noreply.github.com> Date: Wed, 4 Nov 2015 21:37:16 -0500 Subject: [PATCH 4/7] :arrow_up: language-shellscript@0.20.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 8c415d20e..d852549a4 100644 --- a/package.json +++ b/package.json @@ -140,7 +140,7 @@ "language-ruby": "0.60.0", "language-ruby-on-rails": "0.24.0", "language-sass": "0.42.1", - "language-shellscript": "0.19.0", + "language-shellscript": "0.20.0", "language-source": "0.9.0", "language-sql": "0.19.0", "language-text": "0.7.0", From 15368be800aab109a2e799d7ae6b0b4fee827d16 Mon Sep 17 00:00:00 2001 From: Sander van Harmelen Date: Thu, 5 Nov 2015 10:47:23 +0100 Subject: [PATCH 5/7] :arrow_up: language-go@0.40.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index d852549a4..16f66ac57 100644 --- a/package.json +++ b/package.json @@ -123,7 +123,7 @@ "language-css": "0.35.0", "language-gfm": "0.81.0", "language-git": "0.10.0", - "language-go": "0.39.0", + "language-go": "0.40.0", "language-html": "0.42.0", "language-hyperlink": "0.15.0", "language-java": "0.16.1", From 75f286cc55978810d7ec6efe5efe4090b78586ae Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Thu, 5 Nov 2015 09:56:01 -0800 Subject: [PATCH 6/7] :arrow_up: legal-eagle@0.12 --- build/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/package.json b/build/package.json index 308849a93..2ce92de17 100644 --- a/build/package.json +++ b/build/package.json @@ -27,7 +27,7 @@ "grunt-peg": "~1.1.0", "grunt-shell": "~0.3.1", "grunt-standard": "^1.0.2", - "legal-eagle": "~0.11.0", + "legal-eagle": "~0.12.0", "minidump": "~0.9", "npm": "2.13.3", "rcedit": "~0.3.0", From 5b192ea2955c18d15a4328999928765d0f4419f6 Mon Sep 17 00:00:00 2001 From: abe33 Date: Thu, 5 Nov 2015 20:36:22 +0100 Subject: [PATCH 7/7] :art: Fix typo in moveLineUp comment --- src/text-editor.coffee | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/text-editor.coffee b/src/text-editor.coffee index 87848807c..36639251b 100644 --- a/src/text-editor.coffee +++ b/src/text-editor.coffee @@ -866,8 +866,8 @@ class TextEditor extends Model @transact groupingInterval, => fn(selection, index) for selection, index in @getSelectionsOrderedByBufferPosition() - # Move lines intersection the most recent selection or multiple selections up by one row in screen - # coordinates. + # Move lines intersecting the most recent selection or multiple selections + # up by one row in screen coordinates. moveLineUp: -> selections = @getSelectedBufferRanges() selections.sort (a, b) -> a.compare(b) @@ -951,8 +951,8 @@ class TextEditor extends Model @autoIndentSelectedRows() if @shouldAutoIndent() @scrollToBufferPosition([newSelectionRanges[0].start.row, 0]) - # Move lines intersecting the most recent selection or muiltiple selections down by one row in screen - # coordinates. + # Move lines intersecting the most recent selection or muiltiple selections + # down by one row in screen coordinates. moveLineDown: -> selections = @getSelectedBufferRanges() selections.sort (a, b) -> a.compare(b)