From 7f0947ef9bc7f0b1b639c0a67a34f322ddd6d8e0 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Mon, 3 Jun 2013 11:46:24 -0700 Subject: [PATCH] Don't cancel on delay when no tags exist Instead just show the error until explicitly cancelled so the behavior when no tags is the same as the behavior when no tags match the current filter. --- src/packages/symbols-view/lib/symbols-view.coffee | 4 ---- src/packages/symbols-view/spec/symbols-view-spec.coffee | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/packages/symbols-view/lib/symbols-view.coffee b/src/packages/symbols-view/lib/symbols-view.coffee index 9881d6a5f..a434a95b2 100644 --- a/src/packages/symbols-view/lib/symbols-view.coffee +++ b/src/packages/symbols-view/lib/symbols-view.coffee @@ -46,13 +46,10 @@ class SymbolsView extends SelectList @setLoading("Generating symbols...") new TagGenerator(path).generate().done (tags) => if tags.length > 0 - @miniEditor.show() @maxItem = Infinity @setArray(tags) else - @miniEditor.hide() @setError("No symbols found") - setTimeout (=> @cancel()), 2000 toggleProjectSymbols: -> if @hasParent() @@ -72,7 +69,6 @@ class SymbolsView extends SelectList else @miniEditor.hide() @setError("No symbols found") - setTimeout (=> @cancel()), 2000 confirmed : (tag) -> if tag.file and not fsUtils.isFile(project.resolve(tag.file)) diff --git a/src/packages/symbols-view/spec/symbols-view-spec.coffee b/src/packages/symbols-view/spec/symbols-view-spec.coffee index 140024b8c..1707bb758 100644 --- a/src/packages/symbols-view/spec/symbols-view-spec.coffee +++ b/src/packages/symbols-view/spec/symbols-view-spec.coffee @@ -74,7 +74,7 @@ describe "SymbolsView", -> setErrorSpy.callCount > 0 runs -> - expect(rootView.find('.symbols-view')).toExist() + expect(symbolsView).toExist() expect(symbolsView.list.children('li').length).toBe 0 expect(symbolsView.error).toBeVisible() expect(symbolsView.error.text().length).toBeGreaterThan 0