github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-13 08:04:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

Backfill a test for existing --wait functionality

Browse Source
This commit is contained in:
Max Brunsfeld
2018-01-05 14:28:27 -08:00
parent b2337fcc45
commit 7f76320387
2 changed files with 34 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/main-process/atom-application.js
View File

@@ -101,6 +101,7 @@ class AtomApplication extends EventEmitter {
this.socketPath = options.socketPath
this.logFile = options.logFile
this.userDataDir = options.userDataDir
this._killProcess = options.killProcess || process.kill.bind(process)
if (options.test || options.benchmark || options.benchmarkTest) this.socketPath = null
this.pidsToOpenWindows = {}
@@ -880,7 +881,7 @@ class AtomApplication extends EventEmitter {
killProcess (pid) {
try {
const parsedPid = parseInt(pid)
if (isFinite(parsedPid)) process.kill(parsedPid)
if (isFinite(parsedPid)) this._killProcess(parsedPid)
} catch (error) {
if (error.code !== 'ESRCH') {
console.log(`Killing process ${pid} failed: ${error.code != null ? error.code : error.message}`)