From 84b2cabeb3dcb192802cc0f20606787b2c6efdf2 Mon Sep 17 00:00:00 2001
From: Corey Johnson & Nathan Sobo <cj+nathan@github.com>
Date: Fri, 19 Oct 2012 12:42:27 -0600
Subject: [PATCH] Calling `.abortKeyBinding` on an event that wasn't triggered
 by the keymap is ok

Certain events call `abortKeyBinding` to opt out of handling certain keybindings. Snippets does this with tab for example. If it's not a situation where it's appropriate to go to the next tab stop, we let the next binding be triggered, which could insert a tab, for example. But when we trigger events from the event palette, there *is* no next binding. Having a no-op function helps in this situation.
---
 spec/app/keymap-spec.coffee         | 8 +++++++-
 src/stdlib/jquery-extensions.coffee | 2 ++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/spec/app/keymap-spec.coffee b/spec/app/keymap-spec.coffee
index f50875bdb..e8edc660b 100644
--- a/spec/app/keymap-spec.coffee
+++ b/spec/app/keymap-spec.coffee
@@ -86,7 +86,9 @@ describe "Keymap", ->
           expect(insertCharHandler).not.toHaveBeenCalled()
 
         describe "when 'abortKeyBinding' is called on the triggered event", ->
-          it "aborts the current event and tries again with the next-most-specific key binding",  ->
+          [fooHandler1, fooHandler2] = []
+
+          beforeEach ->
             fooHandler1 = jasmine.createSpy('fooHandler1').andCallFake (e) ->
               expect(deleteCharHandler).not.toHaveBeenCalled()
               e.abortKeyBinding()
@@ -95,12 +97,16 @@ describe "Keymap", ->
             fragment.find('.child-node').on 'foo', fooHandler1
             fragment.on 'foo', fooHandler2
 
+          it "aborts the current event and tries again with the next-most-specific key binding",  ->
             target = fragment.find('.grandchild-node')[0]
             keymap.handleKeyEvent(keydownEvent('x', target: target))
             expect(fooHandler1).toHaveBeenCalled()
             expect(fooHandler2).not.toHaveBeenCalled()
             expect(deleteCharHandler).toHaveBeenCalled()
 
+          ffit "does not throw an exception if the event was not triggered by the keymap",  ->
+            fragment.find('.grandchild-node').trigger 'foo'
+
       describe "when the event bubbles to a node that matches multiple selectors", ->
         describe "when the matching selectors differ in specificity", ->
           it "triggers the binding for the most specific selector", ->
diff --git a/src/stdlib/jquery-extensions.coffee b/src/stdlib/jquery-extensions.coffee
index 8e0259b57..ecd07e49d 100644
--- a/src/stdlib/jquery-extensions.coffee
+++ b/src/stdlib/jquery-extensions.coffee
@@ -72,3 +72,5 @@ $.fn.command = (args...) ->
   documentation[eventName] = _.humanizeEventName(eventName)
   @document(documentation)
   @on(args...)
+
+$.Event.prototype.abortKeyBinding = ->