github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-16 01:25:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Guard against PaneAxis as first child

Browse Source 
Pane::findLeftmostSibling expected to return a Pane, not a PaneAxis
This commit is contained in:
Kevin Sawicki
2014-05-05 09:09:25 -07:00
parent 1c514bdc6b
commit 8b5fd64dd4
2 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/pane.coffee
View File

@@ -339,15 +339,19 @@ class Pane extends Model
newPane.activate()
newPane
# If the parent is a horizontal axis, returns its first child;
# otherwise this pane.
# If the parent is a horizontal axis, returns its first child if it is a pane;
# otherwise returns this pane.
findLeftmostSibling: ->
if @parent.orientation is 'horizontal'
@parent.children[0]
[leftmostSibling] = @parent.children
if leftmostSibling instanceof PaneAxis
this
else
leftmostSibling
else
this
# If the parent is a horizontal axis, returns its last child;
# If the parent is a horizontal axis, returns its last child if it is a pane;
# otherwise returns a new pane created by splitting this pane rightward.
findOrCreateRightmostSibling: ->
if @parent.orientation is 'horizontal'