From 8cb0197638e6f2acbcb0603a09b6c077d2cccb91 Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Mon, 24 Nov 2014 16:38:04 -0700 Subject: [PATCH] =?UTF-8?q?Add=20legacy=20=E2=80=98from-top=E2=80=99=20cla?= =?UTF-8?q?ss=20at=20the=20view=20layer,=20not=20the=20model?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This blends in to our approach with the other legacy panel classes. --- src/panel-container-element.coffee | 2 +- src/workspace.coffee | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/panel-container-element.coffee b/src/panel-container-element.coffee index 2c6aa38af..22558b362 100644 --- a/src/panel-container-element.coffee +++ b/src/panel-container-element.coffee @@ -16,7 +16,7 @@ class PanelContainerElement extends HTMLElement panelElement = panel.getView() panelElement.classList.add(@model.getLocation()) if @model.isModal() - panelElement.classList.add("overlay") + panelElement.classList.add("overlay", "from-top") else panelElement.classList.add("panel-#{@model.getLocation()}") diff --git a/src/workspace.coffee b/src/workspace.coffee index ad4ddf520..2158e74dc 100644 --- a/src/workspace.coffee +++ b/src/workspace.coffee @@ -682,8 +682,6 @@ class Workspace extends Model # # Returns a {Panel} addModalPanel: (options={}) -> - # TODO: remove these default classes. They are to supoprt existing themes. - options.className ?= 'overlay from-top' @addPanel('modal', options) addPanel: (location, options) ->