From 5490a8b258a9990d843b568c5be6f630f624679b Mon Sep 17 00:00:00 2001 From: Segev Finer Date: Sat, 16 Dec 2017 23:34:37 +0200 Subject: [PATCH] Initialize ProtocolHandlerInstaller after initializing Config This allows it to correctly read `core.uriHandlerRegistration` and avoids popping the notification even if set to 'never'. Fixes #16201 --- src/atom-environment.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/atom-environment.js b/src/atom-environment.js index 1671ea7c7..50a41fb53 100644 --- a/src/atom-environment.js +++ b/src/atom-environment.js @@ -206,12 +206,13 @@ class AtomEnvironment { this.themes.initialize({configDirPath: this.configDirPath, resourcePath, safeMode, devMode}) this.commandInstaller.initialize(this.getVersion()) - this.protocolHandlerInstaller.initialize(this.config, this.notifications) this.uriHandlerRegistry.registerHostHandler('core', CoreURIHandlers.create(this)) this.autoUpdater.initialize() this.config.load() + this.protocolHandlerInstaller.initialize(this.config, this.notifications) + this.themes.loadBaseStylesheets() this.initialStyleElements = this.styles.getSnapshot() if (params.onlyLoadBaseStyleSheets) this.themes.initialLoadComplete = true