From 0d118afb6b338f9f5b95093498455caf694fdb27 Mon Sep 17 00:00:00 2001 From: Ben Ogle Date: Fri, 12 Feb 2016 15:04:49 -0800 Subject: [PATCH 1/4] Send keyup events through the `keymapManager` --- src/window-event-handler.coffee | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/window-event-handler.coffee b/src/window-event-handler.coffee index f0d616f19..ce08344c6 100644 --- a/src/window-event-handler.coffee +++ b/src/window-event-handler.coffee @@ -15,7 +15,8 @@ class WindowEventHandler @addEventListener(@window, 'focus', @handleWindowFocus) @addEventListener(@window, 'blur', @handleWindowBlur) - @addEventListener(@document, 'keydown', @handleDocumentKeydown) + @addEventListener(@document, 'keyup', @handleDocumentKeyEvent) + @addEventListener(@document, 'keydown', @handleDocumentKeyEvent) @addEventListener(@document, 'drop', @handleDocumentDrop) @addEventListener(@document, 'dragover', @handleDocumentDragover) @addEventListener(@document, 'contextmenu', @handleDocumentContextmenu) @@ -66,7 +67,7 @@ class WindowEventHandler target.addEventListener(eventName, handler) @subscriptions.add(new Disposable(-> target.removeEventListener(eventName, handler))) - handleDocumentKeydown: (event) => + handleDocumentKeyEvent: (event) => @atomEnvironment.keymaps.handleKeyboardEvent(event) event.stopImmediatePropagation() From e3015f6d25313e73b446d236deaa9763b81747b1 Mon Sep 17 00:00:00 2001 From: Ben Ogle Date: Wed, 17 Feb 2016 20:46:41 -0800 Subject: [PATCH 2/4] :arrow_up: keybinding-resolver@0.34.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index c764111bb..a49def252 100644 --- a/package.json +++ b/package.json @@ -96,7 +96,7 @@ "grammar-selector": "0.48.1", "image-view": "0.56.0", "incompatible-packages": "0.25.1", - "keybinding-resolver": "0.33.0", + "keybinding-resolver": "0.34.0", "line-ending-selector": "0.3.1", "link": "0.31.0", "markdown-preview": "0.157.3", From 4bd3bf4187a1cc927c6104bbbd677f581695676b Mon Sep 17 00:00:00 2001 From: Ben Ogle Date: Sun, 21 Feb 2016 13:59:15 -0800 Subject: [PATCH 3/4] :arrow_up: atom-keymap@6.3.1 to support keyup bindings --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index a49def252..09bb824cc 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,7 @@ "electronVersion": "0.36.7", "dependencies": { "async": "0.2.6", - "atom-keymap": "^6.2.0", + "atom-keymap": "^6.3.1", "babel-core": "^5.8.21", "bootstrap": "^3.3.4", "cached-run-in-this-context": "0.4.1", From 6457e0573edf783ca5d95a73e2df7b4a36ed13b6 Mon Sep 17 00:00:00 2001 From: Ben Ogle Date: Mon, 22 Feb 2016 13:28:00 -0800 Subject: [PATCH 4/4] :arrow_up: keybinding-resolver to fix specs --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 09bb824cc..58a17c648 100644 --- a/package.json +++ b/package.json @@ -96,7 +96,7 @@ "grammar-selector": "0.48.1", "image-view": "0.56.0", "incompatible-packages": "0.25.1", - "keybinding-resolver": "0.34.0", + "keybinding-resolver": "0.35.0", "line-ending-selector": "0.3.1", "link": "0.31.0", "markdown-preview": "0.157.3",