github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don't render empty highlights

Browse Source
This commit is contained in:
Nathan Sobo
2014-06-17 14:47:12 -06:00
parent 4832d36ac1
commit 99ba20ae0d
2 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/editor-component.coffee
View File

@@ -233,15 +233,17 @@ EditorComponent = React.createClass
decorationsByScreenRow
getHighlightDecorations: (decorationsByMarkerId) ->
{editor} = @props
filteredDecorations = {}
for id, decorations of decorationsByMarkerId
for decoration in decorations
if decoration.isValid() and decoration.isType('highlight')
# Using decoration.toObject() for comparability sake. This effectively
# caches the current state of the decoration object (importantly, the range).
# We need to cache the range because the Decoration's marker's range changes.
filteredDecorations[id] ?= []
filteredDecorations[id].push decoration.toObject()
for markerId, decorations of decorationsByMarkerId
unless editor.getMarker(markerId).getScreenRange().isEmpty()
for decoration in decorations
if decoration.isValid() and decoration.isType('highlight')
# Using decoration.toObject() for comparability sake. This effectively
# caches the current state of the decoration object (importantly, the range).
# We need to cache the range because the Decoration's marker's range changes.
filteredDecorations[markerId] ?= []
filteredDecorations[markerId].push decoration.toObject()
filteredDecorations
observeEditor: ->